Skip to content

Storing branch commits count in db rather than caching them in memory or redis #33954

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 12 commits into from
Closed

Storing branch commits count in db rather than caching them in memory or redis #33954

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
43472b1
Fix dependency recycle
lunny Mar 20, 2025
269a4fa
Fix bug
lunny Mar 20, 2025
646d24e
Add cron task to update the wrong commits counts
lunny Mar 20, 2025
78b47ba
Add background cron task to fix wrong branch commit count information
lunny Mar 20, 2025
84f5a2d
Fix
lunny Mar 20, 2025
29f6a3f
Fix branch commits ount in pull mirror
lunny Mar 20, 2025
09dc1cd
Some fix
lunny Mar 20, 2025
998f9ff
Remove unused function
lunny Mar 23, 2025
c6558b8
Merge branch 'main' into lunny/cache_branch_commits_count_in_db
lunny Mar 23, 2025
2b343ce
Merge branch 'main' into lunny/cache_branch_commits_count_in_db
lunny Apr 2, 2025
f1521f3
Merge branch 'main' into lunny/cache_branch_commits_count_in_db
lunny Apr 29, 2025
adbea8b
Fix build
lunny Apr 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix build
  • Loading branch information
@lunny
lunny committed Apr 29, 2025
commit adbea8bdb9ee2c989fd72b745d623dec2752313c
10 changes: 5 additions & 5 deletions modules/git/ref.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,13 +84,13 @@ func RefNameFromCommit(shortName string) RefName {
return RefName(shortName)
}

func RefNameFromObjectTypeAndShortName(objectType ObjectType, shortName string) RefName {
switch objectType {
case ObjectBranch:
func RefNameFromRefTypeAndShortName(refType RefType, shortName string) RefName {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should never need it.

Why you know "RefType" but don't know the full "RefName" when using the ref?

switch refType {
case RefTypeBranch:
return RefNameFromBranch(shortName)
case ObjectTag:
case RefTypeTag:
return RefNameFromTag(shortName)
case ObjectCommit:
case RefTypeCommit:
return RefNameFromCommit(shortName)
}
return RefName(shortName)
Expand Down
2 changes: 1 addition & 1 deletion services/repository/files/content.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -135,7 +135,7 @@ func GetContents(ctx context.Context, repo *repo_model.Repository, refCommit *ut
}
selfURLString := selfURL.String()

refName := git.RefNameFromObjectTypeAndShortName(refType, refCommit.InputRef)
refName := git.RefNameFromRefTypeAndShortName(refType, refCommit.InputRef)

commitsCount, _ := context_service.GetRefCommitsCount(ctx, repo.ID, gitRepo, refName)

Expand Down
Loading