Skip to content

Fix panic when comment is nil #34257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 24, 2025
Merged

Fix panic when comment is nil #34257

merged 4 commits into from
Apr 24, 2025

Conversation

lunny
Copy link
Member

@lunny lunny commented Apr 21, 2025

Fix #34254

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 21, 2025
@lunny lunny added type/bug and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 21, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Apr 21, 2025
@lunny lunny added backport/v1.23 This PR should be backported to Gitea 1.23 and removed modifies/go Pull requests that update Go code labels Apr 21, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 21, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Apr 21, 2025
@silverwind
Copy link
Member

Why remove those assertions?

@lunny
Copy link
Member Author

lunny commented Apr 23, 2025

Why remove those assertions?

They are not right. All review requests should not be requested twice. The previous implementation is wrong which will returned the notify result even if that reviewer has been requested.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 23, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 23, 2025
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Apr 24, 2025
@lunny lunny enabled auto-merge (squash) April 24, 2025 01:33
@lunny lunny merged commit e73c113 into go-gitea:main Apr 24, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.25.0 milestone Apr 24, 2025
@GiteaBot
Copy link
Collaborator

I was unable to create a backport for 1.23. @lunny, please send one manually. 🍵

go run ./contrib/backport 34257
...  // fix git conflicts if any
go run ./contrib/backport --continue

@GiteaBot GiteaBot added backport/manual No power to the bots! Create your backport yourself! and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels Apr 24, 2025
lunny added a commit to lunny/gitea that referenced this pull request Apr 24, 2025
@lunny
Fix panic when comment is nil (go-gitea#34257)
b1f196d 
Fix go-gitea#34254
@lunny lunny mentioned this pull request Apr 24, 2025
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Apr 24, 2025
@lunny lunny modified the milestones: 1.25.0, 1.24.0 Apr 24, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Apr 24, 2025
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
319a1c2 
* giteaofficial/main:
  Fix panic when comment is nil (go-gitea#34257)
  Fix various trivial frontend problems (go-gitea#34263)
  update go&js dependencies (go-gitea#34262)
  Fix runner list tmpl (go-gitea#34270)
  Improve "not found" error messages for API (go-gitea#34267)
  Add fullscreen mode as a more efficient operation way to view projects (go-gitea#34081)
lunny added a commit that referenced this pull request Apr 25, 2025
@lunny
Fix panic when comment is nil (#34257) (#34277)
4e5aca6 
Fix #34254
Backport #34257
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@silverwind silverwind silverwind approved these changes

@delvh delvh delvh approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/manual No power to the bots! Create your backport yourself! backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code type/bug
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.

Gitea v1.23.7 crashes on force-push to existing PR
4 participants
@lunny @silverwind @GiteaBot @delvh