-
Notifications
You must be signed in to change notification settings - Fork 18.1k
crypto/x509: validate certificates with unsorted SET values in RDNs #73936
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
crypto/x509: validate certificates with unsorted SET values in RDNs #73936
Conversation
This PR (HEAD: d8a6c99) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/677796. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/677796. |
Message from Lokesh Kumar: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/677796. |
Message from Mateusz Poliwczak: Patch Set 2: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/677796. |
This PR (HEAD: 81ed138) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/677796. Important tips:
|
Message from Lokesh Kumar: Patch Set 2: (3 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/677796. |
Message from Mateusz Poliwczak: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/677796. |
Added check to ensure SET values in RDNs are sorted in ascending order
as required by ASN.1 DER encoding rules (X.690 section 11.6).
When unsorted SET values are detected, reject the certificate with a
"malformed certificate" error.
Fixes #73743