Skip to content

Conversation

@acouvreur
Copy link
Contributor

@acouvreur acouvreur commented Oct 22, 2025

Adds support for private registries endpoints.

See https://docs.github.com/rest/private-registries for more details.

script/generate.sh, script/fmt.sh and script/lint.sh have been run without issue.

Closes #3784

@gmlewis gmlewis changed the title feat: add support for private registries endpoints feat: Add support for private registries endpoints Oct 22, 2025
Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the linter is going to catch some things, but here is some early feedback.

@acouvreur acouvreur requested a review from gmlewis October 22, 2025 02:10
@gmlewis gmlewis added the NeedsReview PR is awaiting a review before merging. label Oct 22, 2025
@codecov
Copy link

codecov bot commented Oct 22, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.54%. Comparing base (036aeb4) to head (8dea44d).
⚠️ Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3785      +/-   ##
==========================================
+ Coverage   91.50%   91.54%   +0.04%     
==========================================
  Files         190      191       +1     
  Lines       17007    17088      +81     
==========================================
+ Hits        15562    15643      +81     
  Misses       1257     1257              
  Partials      188      188              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @acouvreur!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.

cc: @stevehipwell - @alexandear - @zyfy29

@acouvreur acouvreur requested a review from alexandear October 22, 2025 13:28
@gmlewis
Copy link
Collaborator

gmlewis commented Oct 23, 2025

Thank you, @alexandear!
Merging.

@gmlewis gmlewis removed the NeedsReview PR is awaiting a review before merging. label Oct 23, 2025
@gmlewis gmlewis merged commit 12cbac6 into google:master Oct 23, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

add support for organization private registries endpoints

3 participants