-
Notifications
You must be signed in to change notification settings - Fork 2.2k
feat: Add support for private registries endpoints #3785
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for private registries endpoints #3785
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the linter is going to catch some things, but here is some early feedback.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3785 +/- ##
==========================================
+ Coverage 91.50% 91.54% +0.04%
==========================================
Files 190 191 +1
Lines 17007 17088 +81
==========================================
+ Hits 15562 15643 +81
Misses 1257 1257
Partials 188 188 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, @acouvreur!
LGTM.
Awaiting second LGTM+Approval from any other contributor to this repo before merging.
cc: @stevehipwell - @alexandear - @zyfy29
|
Thank you, @alexandear! |
Adds support for private registries endpoints.
See https://docs.github.com/rest/private-registries for more details.
script/generate.sh,script/fmt.shandscript/lint.shhave been run without issue.Closes #3784