Skip to content

test: Ensure Authorization is not set with empty token #3790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 24, 2025
+20 −0
Merged

test: Ensure Authorization is not set with empty token #3790

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions github/github_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,6 +395,26 @@ func TestWithAuthToken(t *testing.T) {
t.Parallel()
validate(t, NewTokenClient(t.Context(), token).Client(), token)
})

t.Run("do not set Authorization when empty token", func(t *testing.T) {
t.Parallel()
c := new(Client).WithAuthToken("")

gotReq := false
ifAuthorizationSet := false
srv := httptest.NewServer(http.HandlerFunc(func(_ http.ResponseWriter, r *http.Request) {
gotReq = true
_, ifAuthorizationSet = r.Header["Authorization"]
}))
_, err := c.client.Get(srv.URL)
assertNilError(t, err)
if !gotReq {
t.Error("request not sent")
}
if ifAuthorizationSet {
t.Error("The header 'Authorization' must not be set")
}
})
}

func TestWithEnterpriseURLs(t *testing.T) {
Expand Down
Loading