Skip to content

chore: fix #412 #622 iOS resolver reference when iOS module not installed #714

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 8 commits into from
Closed

chore: fix #412 #622 iOS resolver reference when iOS module not installed #714

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
aaa9dbb
fix #412 iOS resolver reference when iOS module not installed
StephenHodgson Oct 25, 2024
0bc8e57
updated workflows to use latest versions of action steps
StephenHodgson Oct 30, 2024
303a86e
use py 3.9
StephenHodgson Oct 30, 2024
953142a
revert
StephenHodgson Oct 30, 2024
0352f49
fix stray comma
StephenHodgson Oct 30, 2024
10883aa
set define constraints in export_unity_package.py
StephenHodgson Oct 30, 2024
71eb8d8
properly assign defineConstraints
StephenHodgson Oct 30, 2024
54748d2
fix warnings for expected class type
StephenHodgson Oct 31, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
properly assign defineConstraints
  • Loading branch information
@StephenHodgson
StephenHodgson committed Oct 30, 2024
commit 71eb8d8adfe4a4eaa95b18a33a519796a771afed
3 changes: 2 additions & 1 deletion source/ExportUnityPackage/export_unity_package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1512,7 +1512,8 @@ def set_define_constraints(importer_metadata):
Returns:
Modified importer_metadata.
"""
define_constraints = safe_dict_get_value(importer_metadata, "PluginImporter", {}).get("defineConstraints")
plugin_importer = safe_dict_get_value(importer_metadata, "PluginImporter", default_value={})
define_constraints = plugin_importer.get("defineConstraints")
if define_constraints:
importer_metadata["PluginImporter"]["defineConstraints"] = define_constraints
return importer_metadata
Expand Down