Skip to content

Copy fix #962

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 29, 2025
Merged

Copy fix #962

merged 2 commits into from
May 29, 2025

Conversation

MichaelMacaulay
Copy link
Contributor

No description provided.

@MichaelMacaulay MichaelMacaulay requested a review from a team as a code owner May 27, 2025 16:07
@benface
Copy link
Contributor

benface commented May 27, 2025

@MichaelMacaulay – What are you trying to fix? The original code is the desired version. If you make this change, references to that title will no longer work.

CleanShot 2025-05-27 at 14 07 38@2x

@MichaelMacaulay
Copy link
Contributor Author

MichaelMacaulay commented May 27, 2025

@MichaelMacaulay – What are you trying to fix? The original code is the desired version. If you make this change, references to that title will no longer work.

CleanShot 2025-05-27 at 14 07 38@2x

@benface The folder is currently displayed in lowercase, and it should be all caps.
Screenshot 2025-05-27 at 4 25 33 PM

@benface
Copy link
Contributor

benface commented May 27, 2025

@MichaelMacaulay – Ohhh, well that's because mcp is simply not listed in the relevant _meta.js file (sorry, the screenshot in my previous post was from the _meta.js in token-api... I didn't even notice). When a page or folder exists on disk but is not listed in _meta.js, Nextra automatically adds it to the sidebar (after the items that are listed), and when it's a folder, since there's no other way to give it a sidebar name than with _meta.js, it just uses the folder's name.

tl;dr: mcp: titles.mcp ?? '' should be added to pages/en/subgraphs/_meta.js. :)

@MichaelMacaulay MichaelMacaulay merged commit e40b100 into main May 29, 2025
4 checks passed
@MichaelMacaulay MichaelMacaulay deleted the Copy-fix branch May 29, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants