Skip to content

fix: fix log namespace #2008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 23, 2025
Merged

Conversation

PaulRBerg
Copy link
Contributor

I'm getting these type errors when running tsc --noEmit on a code base that uses @graphprotocol/graph-ts. This is even if I extend from your @graphprotocol/graph-ts/types/tsconfig.base.json file — using TypeScript 5.5.2

bun run tsc --noEmit --project ./the-graph/tsconfig.json
node_modules/@graphprotocol/graph-ts/index.ts:103:9 - error TS2339: Property 'log' does not exist on type 'typeof log'.

103     log.log(Level.CRITICAL, format(msg, args));
            ~~~

node_modules/@graphprotocol/graph-ts/index.ts:113:9 - error TS2339: Property 'log' does not exist on type 'typeof log'.

113     log.log(Level.ERROR, format(msg, args));
            ~~~

node_modules/@graphprotocol/graph-ts/index.ts:122:9 - error TS2339: Property 'log' does not exist on type 'typeof log'.

122     log.log(Level.WARNING, format(msg, args));
            ~~~

node_modules/@graphprotocol/graph-ts/index.ts:131:9 - error TS2339: Property 'log' does not exist on type 'typeof log'.

131     log.log(Level.INFO, format(msg, args));
            ~~~

node_modules/@graphprotocol/graph-ts/index.ts:140:9 - error TS2339: Property 'log' does not exist on type 'typeof log'.

140     log.log(Level.DEBUG, format(msg, args));

This PR fixes the double namespace.

P.S. I assume that the original version works with AssemblyScript, but it's a bad UI/UX to have the AssemblyScript code work but not the TypeScript compilation.

Copy link

changeset-bot bot commented May 3, 2025

🦋 Changeset detected

Latest commit: 1c92f99

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@graphprotocol/graph-ts Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@YaroShkvorets YaroShkvorets merged commit b9b911e into graphprotocol:main Jun 23, 2025
8 checks passed
@PaulRBerg PaulRBerg deleted the fix/log-namespace branch June 23, 2025 20:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants