포스트 조회수 기능 구현 #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hokyunR
commented
Jun 10, 2022
| }, | ||
| }); | ||
|
|
||
| const filledStats = useMemo(() => { |
There was a problem hiding this comment.
[p3] 해당 로직을 별도의 helper 함수로 추출하여 descriptive한 이름을 부여하면 가독성이 좋을 것 같습니다.
yunseoChang
reviewed
Jun 10, 2022
| @@ -212,6 +212,10 @@ const PostViewer: React.FC<PostViewerProps> = ({ | |||
| history.push(`/write?id=${post.id}`); | |||
| }; | |||
|
|
|||
| const onOpenStats = () => { | |||
| history.push(`/post-stats/${post.id}`); | |||
There was a problem hiding this comment.
React router에서 제공하는 hook을 다시 래핑해서 useRouter 훅을 만든 예시도 있어서 신기해서 가져와보았습니다.
hyunsungK
reviewed
Jun 10, 2022
| countMap.set(format(new Date(item.day), 'yyyy-MM-dd'), item.count); | ||
| }); | ||
|
|
||
| const lastDate = new Date(items[0].day); |
There was a problem hiding this comment.
[p5] 일관성 있는 naming rule이 필요할거 같습니다.
lastDate
currentDate
| @@ -35,14 +35,16 @@ declare module '*.png' { | |||
| } | |||
|
|
|||
| declare module '*.webp' { | |||
Mingyu-Song
reviewed
Jun 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://velog.io/@velog/post-stats-update
원래 PR