-
-
Notifications
You must be signed in to change notification settings - Fork 34.1k
Move MQTT debug_info to dataclass #78788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move MQTT debug_info to dataclass #78788
Conversation
Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration ( |
3ac745e
to
28559a3
Compare
Comments were followed up. #78706 is another PR in this collection. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of comments:
- there are a couple of functions where type hints were only partially added
- with
get_mqtt_data
a few variables are unnecessary and the code can be put in a single line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just two more that we have missed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Maybe @cdce8p has some comments before merge?
Merging this now, so I can go in with #78706. any late reviews are still welcome. |
Proposed change
Move MQTT debug_info to dataclass
This is a follow-up PR on #77972
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: