Skip to content

Move MQTT debug_info to dataclass #78788

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 23, 2022

Conversation

jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Sep 19, 2022

Proposed change

Move MQTT debug_info to dataclass

This is a follow-up PR on #77972

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @emontnemery, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@jbouwh jbouwh changed the title Add MQTT debug_info to dataclass Move MQTT debug_info to dataclass Sep 20, 2022
@jbouwh jbouwh force-pushed the mqtt-add-debug-info-to-dataclass branch from 3ac745e to 28559a3 Compare September 21, 2022 07:16
@jbouwh
Copy link
Contributor Author

jbouwh commented Sep 21, 2022

Comments were followed up. #78706 is another PR in this collection.

@jbouwh jbouwh requested a review from epenet September 21, 2022 14:07
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments:

  • there are a couple of functions where type hints were only partially added
  • with get_mqtt_data a few variables are unnecessary and the code can be put in a single line

Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two more that we have missed

Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Maybe @cdce8p has some comments before merge?

@jbouwh jbouwh requested a review from cdce8p September 22, 2022 10:17
@jbouwh
Copy link
Contributor Author

jbouwh commented Sep 23, 2022

Merging this now, so I can go in with #78706. any late reviews are still welcome.

@jbouwh jbouwh merged commit 81514b0 into home-assistant:dev Sep 23, 2022
@jbouwh jbouwh deleted the mqtt-add-debug-info-to-dataclass branch September 23, 2022 18:55
@github-actions github-actions bot locked and limited conversation to collaborators Sep 24, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants