Skip to content

Conversation

@KhizerRehan
Copy link
Contributor

@KhizerRehan KhizerRehan commented Oct 30, 2025

What this PR does / why we need it:
This PR fixes an issue where cluster configuration details were not being displayed when a preset was selected in the cluster summary view

Before:
e.g Dev (Provider: Openstack)
Screenshot 2025-10-30 at 12 50 53 PM

After:
Screenshot 2025-10-30 at 12 50 00 PM

What type of PR is this?
/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Fix cluster summary not displaying provider details when using presets

Documentation:

NONE

@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Oct 30, 2025
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from khizerrehan. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@KhizerRehan KhizerRehan changed the title fix: Fix display details when preset selected in cluster summary Fix display details when preset selected in cluster summary Oct 30, 2025
@kubermatic-bot kubermatic-bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Oct 30, 2025
@codecov
Copy link

codecov bot commented Oct 30, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 44.91%. Comparing base (1d801ec) to head (af5fec9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7673   +/-   ##
=======================================
  Coverage   44.91%   44.91%           
=======================================
  Files         443      443           
  Lines       19883    19883           
  Branches     3237     3237           
=======================================
  Hits         8931     8931           
  Misses      10314    10314           
  Partials      638      638           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants