-
Notifications
You must be signed in to change notification settings - Fork 128
Adding 2fa feature for Vue Starter #120
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Why bring in unplugin-vue-components? |
@@ -40,6 +41,7 @@ | |||
"typescript": "^5.2.2", | |||
"vite": "^6.2.0", | |||
"vue": "^3.5.13", | |||
"vue-input-otp": "^0.2.2", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This package isn't used anywhere
import HeadingSmall from '@/components/HeadingSmall.vue'; | ||
import { Button } from '@/components/ui/button'; | ||
import { Badge } from '@/components/ui/badge'; | ||
import { PinInputInput, PinInputRoot } from 'reka-ui' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm curious, what's the reason for using Reka UI's Pin Input
component directly instead of going through the shadcn/vue integration?
https://www.shadcn-vue.com/docs/components/pin-input.html
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I experienced issues with the ShadCN pin input not functioning and displaying correctly. Instead of submitting an issue and waiting to hear back about the fixes, I decided to go right to the source and use the component from the underlying library.
If you'd like to give the ShadCN Vue Pin Input a try, please let me know how it goes. It could have been user error, but I spent over an hour trying to debug some issues.
Co-authored-by: Luke Okomilo <[email protected]>
@tnylea the livewire PR is not using I’m curious why the team decided to rewrite backend logic in all the starter kits instead of using Fortify, since it already includes these features (like this option to configure secret length laravel/fortify#568) |
@ibrunotome Thats right! All of this starterkids can use fortify! Soo much work for nothing.... |
@ibrunotome and @David-Grass-Feria, thanks for letting me know about the This PR is not final and there are still many iterations that we are going through. Many of the logic from Fortify has been ported over and we are still working on finalizing this functionality. I appreciate the input. Thanks. |
This PR will add Two Factor Auth Functionality to the Vue Starter Kit.
In the settings page, users will now see a Two-Factor Auth button.
Clicking this will take them to their 2FA settings page.
They can enable 2FA and they will see a modal with a QR code and secret key.
After scanning the QR code with an authenticator app, they can click on continue and they'll see the 2FA confirmation screen.
After the user successfully confirms they will see that 2FA is now active on their account.
They will also see their recovery codes on the previous screen. Now, upon logging in as their user, they will also have to verify a 2FA code.
You will also find the relevant PR's for this feature in the other Starter Kits.
Other Starter Kit 2FA Feature PR's
React: github.com/laravel/react-starter-kit/pull/101
Livewire: github.com/laravel/livewire-starter-kit/pull/84