Skip to content

[WEB-3958] chore: allow members and admins to create api tokens #6979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 30, 2025

Conversation

sangeethailango
Copy link
Member

@sangeethailango sangeethailango commented Apr 25, 2025

Description

This PR will allow admins and members to create API tokens.

Summary by CodeRabbit

  • Refactor
    • Updated access permissions for API token management to use a different permission level.

Copy link
Contributor

coderabbitai bot commented Apr 25, 2025

Walkthrough

The changes update the permission requirements for the ApiTokenEndpoint and ServiceApiTokenEndpoint classes in the API views. The import statement now replaces WorkspaceOwnerPermission with WorkspaceEntityPermission. Correspondingly, the permission_classes attribute for both endpoints is switched from [WorkspaceOwnerPermission] to [WorkspaceEntityPermission]. No other logic or structural modifications are present.

Changes

File(s) Change Summary
apiserver/plane/app/views/api.py Replaced import of WorkspaceOwnerPermission with WorkspaceEntityPermission. Updated permission_classes in both ApiTokenEndpoint and ServiceApiTokenEndpoint from [WorkspaceOwnerPermission] to [WorkspaceEntityPermission].

Poem

A hop and a skip, permissions anew,
The endpoints now check what more rabbits can do.
With entities in mind, not just the owner’s might,
The API’s gate shines a broader light.
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a5286e4 and 1e84c35.

📒 Files selected for processing (1)
  • apiserver/plane/app/views/api.py (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apiserver/plane/app/views/api.py
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Analyze (javascript)
  • GitHub Check: Analyze (python)
✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@pushya22 pushya22 marked this pull request as draft April 25, 2025 12:45
@sangeethailango sangeethailango changed the title chore: allow members and admins to create api tokens [WEB-3958] chore: allow members and admins to create api tokens Apr 25, 2025
Copy link

makeplane bot commented Apr 25, 2025

Pull Request Linked with Plane Work Items

Comment Automatically Generated by Plane

@sriramveeraghanta sriramveeraghanta marked this pull request as ready for review April 30, 2025 14:21
@sriramveeraghanta sriramveeraghanta merged commit 1e46290 into preview Apr 30, 2025
5 of 6 checks passed
@sriramveeraghanta sriramveeraghanta deleted the api-token-permission branch April 30, 2025 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants