Skip to content

FeaturesLineWidget #200

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: main
Choose a base branch
from
Open

FeaturesLineWidget #200

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
35e5808
Create line.py
zoccoler Oct 28, 2022
bfb655a
Update line.py
zoccoler Nov 21, 2022
e2eb48f
remove minimum size
zoccoler Jun 16, 2023
22f7ce6
Merge branch 'main' into line_plot_widget
zoccoler Jun 29, 2023
86ac6d2
WIP: re-factor line widgets
zoccoler Jun 30, 2023
5891f7f
remove unused packages
zoccoler Jul 3, 2023
c2a0586
add examples
zoccoler Jul 3, 2023
4607213
revert changes in base
zoccoler Jul 29, 2023
7fff195
remove line widget
zoccoler Jul 29, 2023
ece6ed1
replace label by object_id
zoccoler Aug 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
revert changes in base
  • Loading branch information
@zoccoler
zoccoler committed Jul 29, 2023
commit 460721381ac0b244531bd2ff84ef1d0059eb8404
1 change: 1 addition & 0 deletions src/napari_matplotlib/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -209,6 +209,7 @@ def current_z(self) -> int:
"""
Current z-step of the napari viewer.
"""
return self.viewer.dims.current_step[0]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
return self.viewer.dims.current_step[0]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume the line self.viewer.dims.current_step[-3] is a bug fix below for datasets that have >= 4 dimensions?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can drop it for now since it does no affect this PR anymore. It had to do with other dimensions, yes

if self.viewer.dims.ndim < 3:
return slice(None)
return self.viewer.dims.current_step[-3]
Expand Down