Skip to content

Conversation

@HeeManSu
Copy link
Contributor

No description provided.

@HeeManSu HeeManSu marked this pull request as draft December 15, 2024 18:49
@HeeManSu HeeManSu marked this pull request as ready for review December 18, 2024 11:09
@viferga
Copy link
Member

viferga commented Dec 18, 2024

This needs a test and review the existing breaking test, otherwise I will not merge it.

@viferga viferga marked this pull request as draft December 18, 2024 16:03
@viferga
Copy link
Member

viferga commented Dec 18, 2024

@HeeManSu I have added a secret called: METACALL_AUTH_EXPIRED_TOKEN, with this you will be able to test the token expirity.

Basically when you try to login with an expired token, it should show something like:
The token has expired, login again:

And then the normal login.

@HeeManSu
Copy link
Contributor Author

@HeeManSu I have added a secret called: METACALL_AUTH_EXPIRED_TOKEN, with this you will be able to test the token expirity.

Basically when you try to login with an expired token, it should show something like: The token has expired, login again:

And then the normal login.

okay.

@HeeManSu HeeManSu marked this pull request as ready for review January 23, 2025 20:35
@viferga viferga marked this pull request as draft February 13, 2025 10:43
@viferga
Copy link
Member

viferga commented Feb 13, 2025

What's left?

@HeeManSu
Copy link
Contributor Author

What's left?

Tests to add and the pipeline should succeed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants