Skip to content

Legacy/v0 #13

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Legacy/v0 #13

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
c8e1b1a
Don't alter the whitepace in inc files
rwstauner Oct 18, 2014
99b3f4e
Comment on edit required for shift+enter with behave
rwstauner Oct 18, 2014
5135a4f
Put space between settings view item arguments
rwstauner Oct 18, 2014
eb5d53e
Change "api docs" link from wiki to repo
rwstauner Jun 20, 2015
d384852
Rebuild
rwstauner Jun 20, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .editorconfig
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,3 +15,8 @@ charset = utf-8

trim_trailing_whitespace = true
insert_final_newline = true

# Don't mess with stuff in inc.
[app/inc/**]
trim_trailing_whitespace = false
insert_final_newline = false
2 changes: 1 addition & 1 deletion app/inc/behave.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -438,7 +438,7 @@

if(!utils.fenceRange()){ return; }

if (e.keyCode == 13 && e.shiftKey !== true) {
if (e.keyCode == 13 && e.shiftKey !== true) { // NOTE: EDITED

utils.preventDefaultEvent(e);
utils._callHook('enter:before');
Expand Down
2 changes: 1 addition & 1 deletion app/scripts/template/sidebar.htm
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
</li>
<li class="nav-header examples">Examples</li>
<li class="nav-header">Resources</li>
<li><a href="https://github.com/CPAN-API/cpan-api/wiki/API-docs">API Documentation</a></li>
<li><a href="https://github.com/CPAN-API/cpan-api/blob/master/docs/API-docs.md">API Documentation</a></li>
<li><a href="https://github.com/CPAN-API/metacpan-explorer/issues">Report Issue</a></li>
<li><a href="https://github.com/CPAN-API/metacpan-explorer">Fork Me</a></li>
</ul>
6 changes: 6 additions & 0 deletions app/scripts/view/request.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,15 @@ define([
return View.extend({
name: "request",
template: template,

events: {
"keydown textarea": function(e) {
// Shift + Enter to send request.
// NOTE: Our copy of behave has an edit on line 441 to disable behave's
// enterKey functionality when shift is pressed.
// Behave offers hooks for keydown as well as enter:before but they both
// fire after behave's enterKey function has started, so I think it's
// too late... I think we're stuck with the edit.
if((e.keyCode || e.which) === 13 && e.shiftKey === true) {
this.model.request();
return false;
Expand Down
2 changes: 1 addition & 1 deletion app/scripts/view/settings.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ define([
item: function() {
return [
'<li class="list-group-item"><label>',
_.toArray(arguments).join(''),
_.toArray(arguments).join(' '),
'</label></li>'
].join('');
}
Expand Down
2 changes: 1 addition & 1 deletion build/app.js
View file
Open in desktop

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions build/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@
<meta charset="utf-8">
<title>MetaCPAN Explorer</title>
<link rel="shortcut icon" href="//metacpan.org/static/icons/favicon.ico">
<link rel="stylesheet" type="text/css" href="styles.css?bust=i1a6yapo">
<script type="text/javascript" src="app.js?bust=i1a6yapo"></script>
<link rel="stylesheet" type="text/css" href="styles.css?bust=ib58mx88">
<script type="text/javascript" src="app.js?bust=ib58mx88"></script>
</head>
<body>
<noscript>This page requires JavaScript.</noscript>
Expand Down