Skip to content

Conversation

@kfricke
Copy link

@kfricke kfricke commented Oct 8, 2016

The delay method was wasting an argument, static class member and only got called from one location.

@pfalcon
Copy link
Contributor

pfalcon commented Oct 8, 2016

umqtt.robust.MQTTClient is intended to be configurable, extensible, and subclassable by a user.

@kfricke
Copy link
Author

kfricke commented Oct 8, 2016

But a base class should at least show reasonable behaviour and wasteless implementation.

@pfalcon
Copy link
Contributor

pfalcon commented Oct 8, 2016

And that's exactly what it does.

@kfricke
Copy link
Author

kfricke commented Oct 9, 2016

The argument i passed to the method delay is never used. I did assume that your intent was to pass a dynamic delay, which does increase over time when the connection keeps failing.
Dropping the method was just another brave brevity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants