Skip to content

Conversation

@jongio
Copy link

@jongio jongio commented Dec 20, 2016

I removed the readonly attribute from the txtCode textarea so users can edit the code. I also store each code sample and any modifications the user makes to it, in session so their changes remain even after they navigate to another code sample.

@msftclas
Copy link

Hi @jonbgallant, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!


It looks like you're a Microsoft contributor (Jon Gallant). If you're full-time, we DON'T require a Contribution License Agreement. If you are a vendor, please DO sign the electronic Contribution License Agreement. It will take 2 minutes and there's no faxing! https://cla.microsoft.com.

TTYL, MSBOT;

@msftclas msftclas added the documentation Improvements or additions to documentation label Dec 20, 2016
Copy link
Contributor

@ali-hamud ali-hamud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Jon,

A really appreciate your well to help here.
actually we wanted to do that, to enable users to write there own code, and this makes sense.

There is one problem:
In your changes you use eval function, which isn't safe.
we didn't want to use it.
we are looking into another solution which copies the user to an iframe, and then the code will be part of sandboxed iframe.

@ali-hamud ali-hamud closed this Mar 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation Improvements or additions to documentation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants