CDRIVER-5901 support auto encryption in unified tests #2004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevinAlbs
reviewed
May 5, 2025
Co-authored-by: Kevin Albertson <[email protected]>
kevinAlbs
reviewed
May 9, 2025
There was a problem hiding this comment.
Remove the legacy fle2v2-BypassQueryAnalysis.json test file (and others) since they are now redundant with the unified tests and no longer need to be run in the C driver.
| bson_as_canonical_extended_json (&expected_event, NULL), | ||
| bson_as_canonical_extended_json (eiter->serialized, NULL)); | ||
| break; | ||
| } while ((eiter = eiter->next) && !matched); |
There was a problem hiding this comment.
Suggest reverting most changes in this function. I expect the only needed change to event matching is to ignore the extra listCollections events generated by libmongoc. Applying this commit appears to pass with existing tests: 8db0e04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Evergreen: https://spruce.mongodb.com/version/681bf91b5bf32b0007c731d6