-
Notifications
You must be signed in to change notification settings - Fork 1.3k
CSHARP-4918: Release notes automation #1680
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR automates the generation and publication of release notes while also introducing new CI checks for pull requests.
- Updated release note processing in evergreen/release-notes.py to handle special characters and improve HTTP error handling.
- Added a new GitHub Actions workflow (.github/workflows/pr.yml) to validate PR labels, title content, and formatting.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
evergreen/release-notes.py | Updated title encoding and HTTP error handling in release notes logic. |
.github/workflows/pr.yml | Introduced a new workflow to enforce PR label and title requirements. |
.github/workflows/pr.yml
Outdated
name: Pull Request validation. | ||
runs-on: ubuntu-latest | ||
steps: | ||
- name: Validate label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use the same format for step names?
"Pull Request should have a label."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
.github/workflows/pr.yml
Outdated
exit 1 | ||
|
||
- name: Title should contain Jira ticket. | ||
if: ${{ always() && !(contains(github.event.pull_request.title, 'CSHARP-')) }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there startsWith
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, done.
.github/workflows/pr.yml
Outdated
run: | | ||
exit 1 | ||
|
||
- name: Title should mention Jira ticket. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should start with with a Jira ticket.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
.github/workflows/pr.yml
Outdated
run: | | ||
exit 1 | ||
|
||
- name: Title should not end with period or elipses |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
consistency: periods everywhere or nowhere.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.