Skip to content

CSHARP-4918: Release notes automation #1680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 9, 2025
Merged

Conversation

sanych-sun
Copy link
Member

No description provided.

@sanych-sun sanych-sun requested a review from a team as a code owner May 2, 2025 00:17
@sanych-sun sanych-sun requested review from adelinowona and removed request for a team May 2, 2025 00:17
@sanych-sun sanych-sun changed the title CSHARP-4918: Release notes automation HARP-4918: Release notes automation. May 2, 2025
@sanych-sun sanych-sun changed the title HARP-4918: Release notes automation. CSHARP-4918: Release notes automation May 2, 2025
@sanych-sun sanych-sun requested review from BorisDog and removed request for adelinowona May 2, 2025 00:18
@BorisDog BorisDog requested a review from Copilot May 2, 2025 18:33
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR automates the generation and publication of release notes while also introducing new CI checks for pull requests.

  • Updated release note processing in evergreen/release-notes.py to handle special characters and improve HTTP error handling.
  • Added a new GitHub Actions workflow (.github/workflows/pr.yml) to validate PR labels, title content, and formatting.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.

File Description
evergreen/release-notes.py Updated title encoding and HTTP error handling in release notes logic.
.github/workflows/pr.yml Introduced a new workflow to enforce PR label and title requirements.

@sanych-sun sanych-sun changed the title CSHARP-4918: Release notes automation CSHARP-4918: Release notes automation. May 2, 2025
@sanych-sun sanych-sun changed the title CSHARP-4918: Release notes automation. CSHARP-4918: Release notes automation… May 2, 2025
name: Pull Request validation.
runs-on: ubuntu-latest
steps:
- name: Validate label.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use the same format for step names?
"Pull Request should have a label."

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

exit 1

- name: Title should contain Jira ticket.
if: ${{ always() && !(contains(github.event.pull_request.title, 'CSHARP-')) }}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there startsWith?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, done.

Oleksandr Poliakov added 2 commits May 9, 2025 15:45
@sanych-sun sanych-sun changed the title CSHARP-4918: Release notes automation… "CSHARP-4918": Release notes automation… May 9, 2025
@sanych-sun sanych-sun changed the title "CSHARP-4918": Release notes automation… CSHARP-4918: Release notes automation May 9, 2025
@sanych-sun sanych-sun added the chore Label to hide PR from generated Release Notes label May 9, 2025
@sanych-sun sanych-sun requested a review from BorisDog May 9, 2025 22:49
run: |
exit 1

- name: Title should mention Jira ticket.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should start with with a Jira ticket.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

run: |
exit 1

- name: Title should not end with period or elipses
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

consistency: periods everywhere or nowhere.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

Oleksandr Poliakov added 2 commits May 9, 2025 16:00
@sanych-sun sanych-sun requested a review from BorisDog May 9, 2025 23:02
@sanych-sun sanych-sun added chore Label to hide PR from generated Release Notes and removed chore Label to hide PR from generated Release Notes labels May 9, 2025
Copy link
Contributor

@BorisDog BorisDog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sanych-sun sanych-sun merged commit 79d97ed into mongodb:main May 9, 2025
2 of 4 checks passed
@sanych-sun sanych-sun deleted the csharp4918 branch May 9, 2025 23:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Label to hide PR from generated Release Notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants