-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Add Client Metadata Update Support. #1708
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from 1 commit
9753f28
889d5c8
4b3065c
2a684bf
28c1844
371ce0b
972fe9d
bcf9cc8
179b262
bc43ba0
3f5fc91
61192d8
e9f8dd6
95c1bb1
dd63a49
89d67bb
8a18d39
f296d0c
a8dc4fb
8ade58b
71350fa
9890aa1
28f7d88
246a040
8a58294
15ecef8
5c7a6e3
f466d08
3132541
d961447
74d8558
31ef18e
38ba5e6
edafc54
6aa0a1e
dab5451
1550122
b5c4c20
b6b4d67
d43972d
73bdbd8
66a5913
26246f0
843d890
850ebe7
d0cabe4
cb40b6a
c44200f
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -0,0 +1,49 @@ | ||||||
/* | ||||||
* Copyright 2008-present MongoDB, Inc. | ||||||
* | ||||||
* Licensed under the Apache License, Version 2.0 (the "License"); | ||||||
* you may not use this file except in compliance with the License. | ||||||
* You may obtain a copy of the License at | ||||||
* | ||||||
* http://www.apache.org/licenses/LICENSE-2.0 | ||||||
* | ||||||
* Unless required by applicable law or agreed to in writing, software | ||||||
* distributed under the License is distributed on an "AS IS" BASIS, | ||||||
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||||||
* See the License for the specific language governing permissions and | ||||||
* limitations under the License. | ||||||
*/ | ||||||
|
||||||
package com.mongodb.internal.connection; | ||||||
|
||||||
import com.mongodb.MongoDriverInformation; | ||||||
import com.mongodb.lang.Nullable; | ||||||
import org.bson.BsonDocument; | ||||||
|
||||||
import static com.mongodb.internal.connection.ClientMetadataHelper.createClientMetadataDocument; | ||||||
jyemin marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
import static com.mongodb.internal.connection.ClientMetadataHelper.updateClientMedataDocument; | ||||||
|
||||||
/** | ||||||
* Represents metadata of the current MongoClient. | ||||||
* | ||||||
* <p>This class is not part of the public API and may be removed or changed at any time</p> | ||||||
*/ | ||||||
public class ClientMetadata { | ||||||
private volatile BsonDocument clientMetadataBsonDocument; | ||||||
jyemin marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||
|
||||||
public ClientMetadata(@Nullable final String applicationName, final MongoDriverInformation mongoDriverInformation) { | ||||||
this.clientMetadataBsonDocument = createClientMetadataDocument(applicationName, mongoDriverInformation); | ||||||
} | ||||||
|
||||||
/** | ||||||
* Returns mutable BsonDocument that represents the client metadata. | ||||||
*/ | ||||||
public BsonDocument getBsonDocument() { | ||||||
return clientMetadataBsonDocument; | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Return a defensive copy (instead of a reference to this mutable instance?)
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We mostly pass mutable There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I'm fine without defensive copy if it's consistent throughout the codebase. |
||||||
} | ||||||
|
||||||
public void append(final MongoDriverInformation mongoDriverInformation) { | ||||||
this.clientMetadataBsonDocument = updateClientMedataDocument(clientMetadataBsonDocument, mongoDriverInformation); | ||||||
} | ||||||
} | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Now that we have a proper
ClientMetadata
class that is meant to be instantiated, it seems like we no longer need a separateClientMetadataHelper
class, instead moving the methods of that class into this one.