PYTHON-4542 Improved sessions API #2335
Draft
+82
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
aclark4life
commented
May 7, 2025
aclark4life
commented
- Via context variable.
- Via context variable.
ShaneHarvey
requested changes
May 7, 2025
| @@ -222,6 +224,7 @@ def __init__( | |||
| ) | |||
| self._default_transaction_options = default_transaction_options | |||
| self._snapshot = snapshot | |||
| self._bind = bind | |||
There was a problem hiding this comment.
We have to bind/unbind the session in ClientSession.__enter__/__exit__. That way the stack of sessions is managed correctly (ie we call _SESSION.reset(token)). Think about how nested cases will work:
session1 = client.start_session(bind=True)
with session1:
session2 = client.start_session(bind=True)
with session2:
coll.find_one() # uses session2
coll.find_one() # uses session1
coll.find_one() # uses implicit session
ShaneHarvey
reviewed
May 8, 2025
test/asynchronous/test_session.py
Outdated
| with session2: | ||
| coll.find_one() # uses session2 | ||
| coll.find_one() # uses session1 | ||
| coll.find_one() # uses implicit session |
There was a problem hiding this comment.
This test has to actually verify the correct sessions are used via command monitoring events.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.