[DISCO-3253] Fix gcs client auth error for curated recommendations #900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Herraj
commented
Apr 17, 2025
ncloudioj
approved these changes
Apr 21, 2025
Herraj
force-pushed
the
disco-3253-fix-gcs-client-auth-errors-for-curated-recommendations
branch
from
2dc08fe to
343034e
Compare
Herraj
deleted the
disco-3253-fix-gcs-client-auth-errors-for-curated-recommendations
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
References
JIRA: DISCO-3253
Description
We were seeing errors about the gcs client initializing failing to find any credentials. We fixed this error in the
gcs_uploader.pymodule. The reason this occurs is that it is looking for an explicitcredentialsargument but if none is passed, it tries to pull the ADC file from the google project. However, when running locally, we don't have an ADC file hence adding this check.PR Review Checklist
Put an
xin the boxes that apply[DISCO-####], and has the same title (if applicable)[load test: (abort|skip|warn)]keywords are applied to the last commit message (if applicable)