BUG#35114864 Improve NOTE: The Cluster's group_replication_view_change_uuid

This patch improves the note shown when rescanning a cluster and the
group_replication_view_change_uuid var is set (persisted) but not yet
being used.

The new note is more explicit regarding the interaction between the var
and if the Cluster is to be used in a ClusterSet. Also, a warning
telling the user to call rebootClusterFromCompleteOutage (to force the
var to be used) was removed, mainly because it is unnecessary: if the
user tries to create a ClusterSet, a check is made and the command fails
if group_replication_view_change_uuid hasn't the correct value.

Change-Id: I76c2427ad7cee300c0270f7a57d5a818f75cbf58
(cherry picked from commit 2012fb06bc07c4a0d1c88c41fb4cf7d20c0e80b1)

Author: joaosigma

modules/adminapi/cluster/rescan.cc

@@ -690,8 +690,6 @@ void Rescan::ensure_view_change_uuid_set() {
       Precondition_checker::k_min_cs_version)
     return;
 
-  auto console = mysqlsh::current_console();
-
   // Check if group_replication_view_change_uuid is already set on the cluster
   std::shared_ptr<Instance> cluster_instance = m_cluster->get_cluster_server();
   auto view_change_uuid = cluster_instance->get_sysvar_string(
@@ -707,16 +705,19 @@ void Rescan::ensure_view_change_uuid_set() {
             ->get_persisted_value("group_replication_view_change_uuid")
             .value_or("");
 
+    auto console = mysqlsh::current_console();
+
     if (!view_change_uuid_persisted.empty() &&
         view_change_uuid_persisted != view_change_uuid) {
-      console->print_note(
-          "The Cluster's group_replication_view_change_uuid is set but not "
-          "yet effective");
+      console->print_warning(
+          "The current Cluster group_replication_view_change_uuid setting does "
+          "not allow ClusterSet to be implemented, because it's set but not "
+          "yet effective.");
 
       skip_md_mismatch_check = true;
     } else {
       console->print_note(
-          "The Cluster's group_replication_view_change_uuid is not set");
+          "The Cluster's group_replication_view_change_uuid is not set.");
       console->print_info(
           "Generating and setting a value for "
           "group_replication_view_change_uuid...");
@@ -729,11 +730,10 @@ void Rescan::ensure_view_change_uuid_set() {
       auto cfg = m_cluster->create_config_object({}, false, true);
 
       cfg->set("group_replication_view_change_uuid", view_change_uuid);
-
       cfg->apply();
     }
 
-    console->print_warning(
+    console->print_note(
         "The Cluster must be completely taken OFFLINE and restarted "
         "(<<<dba.rebootClusterFromCompleteOutage>>>()) for the settings to "
         "be effective");
@@ -996,7 +996,7 @@ shcore::Value Rescan::execute() {
 
     if (view_change_uuid == "AUTOMATIC") {
       if (m_options.update_view_change_uuid.is_null()) {
-        console->print_warning(
+        console->print_note(
             "The Cluster is not configured to use "
             "'group_replication_view_change_uuid', which is required "
             "for InnoDB ClusterSet. Configuring it requires a full Cluster "

unittest/scripts/auto/js_adminapi/scripts/cluster_rescan.js

@@ -672,23 +672,23 @@ shell.options["useWizards"] = false;
 // Validate output with interactive disabled
 EXPECT_NO_THROWS(function() { cluster.rescan(); });
 
-EXPECT_OUTPUT_CONTAINS("WARNING: The Cluster is not configured to use 'group_replication_view_change_uuid', which is required for InnoDB ClusterSet. Configuring it requires a full Cluster reboot.");
+EXPECT_OUTPUT_CONTAINS("NOTE: The Cluster is not configured to use 'group_replication_view_change_uuid', which is required for InnoDB ClusterSet. Configuring it requires a full Cluster reboot.");
 EXPECT_OUTPUT_CONTAINS("Use the 'updateViewChangeUuid' option to generate and configure a value for the Cluster.");
 WIPE_STDOUT();
 
 // Use the option and validate it's successful
 EXPECT_NO_THROWS(function() { cluster.rescan({updateViewChangeUuid: true}); });
 
-EXPECT_OUTPUT_CONTAINS("NOTE: The Cluster's group_replication_view_change_uuid is not set");
+EXPECT_OUTPUT_CONTAINS("NOTE: The Cluster's group_replication_view_change_uuid is not set.");
 EXPECT_OUTPUT_CONTAINS("Generating and setting a value for group_replication_view_change_uuid...");
-EXPECT_OUTPUT_CONTAINS("WARNING: The Cluster must be completely taken OFFLINE and restarted (dba.rebootClusterFromCompleteOutage()) for the settings to be effective");
+EXPECT_OUTPUT_CONTAINS("NOTE: The Cluster must be completely taken OFFLINE and restarted (dba.rebootClusterFromCompleteOutage()) for the settings to be effective");
 EXPECT_OUTPUT_CONTAINS("Updating group_replication_view_change_uuid in the Cluster's metadata...");
 WIPE_STDOUT();
 
 // Do not restart yet and confirm that cluster.rescan() detects a restart is needed for the change to be effective
 EXPECT_NO_THROWS(function() { cluster.rescan({updateViewChangeUuid: true}); });
-EXPECT_OUTPUT_CONTAINS("NOTE: The Cluster's group_replication_view_change_uuid is set but not yet effective");
-EXPECT_OUTPUT_CONTAINS("WARNING: The Cluster must be completely taken OFFLINE and restarted (dba.rebootClusterFromCompleteOutage()) for the settings to be effective");
+EXPECT_OUTPUT_CONTAINS("WARNING: The current Cluster group_replication_view_change_uuid setting does not allow ClusterSet to be implemented, because it's set but not yet effective.");
+EXPECT_OUTPUT_CONTAINS("NOTE: The Cluster must be completely taken OFFLINE and restarted (dba.rebootClusterFromCompleteOutage()) for the settings to be effective");
 WIPE_STDOUT();
 
 // Restart the instances and reboot it from complete outage after rescan() changed group_replication_view_change_uuid
@@ -731,9 +731,9 @@ EXPECT_EQ(view_change_uuid, view_change_uuid_md);
 
 // cluster.rescan() must not warn or act if the target cluster has group_replication_view_change_uuid set
 EXPECT_NO_THROWS(function() { cluster.rescan(); });
-EXPECT_OUTPUT_NOT_CONTAINS("NOTE: The Cluster's group_replication_view_change_uuid is not set");
+EXPECT_OUTPUT_NOT_CONTAINS("NOTE: The Cluster's group_replication_view_change_uuid is not set.");
 EXPECT_OUTPUT_NOT_CONTAINS("Generating and setting a value for group_replication_view_change_uuid...");
-EXPECT_OUTPUT_NOT_CONTAINS("WARNING: The Cluster must be completely taken OFFLINE and restarted (dba.rebootClusterFromCompleteOutage()) for the settings to be effective");
+EXPECT_OUTPUT_NOT_CONTAINS("NOTE: The Cluster must be completely taken OFFLINE and restarted (dba.rebootClusterFromCompleteOutage()) for the settings to be effective");
 EXPECT_OUTPUT_NOT_CONTAINS("Updating group_replication_view_change_uuid in the Cluster's metadata...");
 WIPE_STDOUT();
 
@@ -750,10 +750,10 @@ testutil.expectPrompt("Would you like 'group_replication_view_change_uuid' to be
 
 EXPECT_NO_THROWS(function() { cluster.rescan(); });
 
-EXPECT_OUTPUT_CONTAINS("WARNING: The Cluster is not configured to use 'group_replication_view_change_uuid', which is required for InnoDB ClusterSet. Configuring it requires a full Cluster reboot.");
+EXPECT_OUTPUT_CONTAINS("NOTE: The Cluster is not configured to use 'group_replication_view_change_uuid', which is required for InnoDB ClusterSet. Configuring it requires a full Cluster reboot.");
 
 EXPECT_OUTPUT_CONTAINS("Generating and setting a value for group_replication_view_change_uuid...");
-EXPECT_OUTPUT_CONTAINS("WARNING: The Cluster must be completely taken OFFLINE and restarted (dba.rebootClusterFromCompleteOutage()) for the settings to be effective");
+EXPECT_OUTPUT_CONTAINS("NOTE: The Cluster must be completely taken OFFLINE and restarted (dba.rebootClusterFromCompleteOutage()) for the settings to be effective");
 EXPECT_OUTPUT_CONTAINS("Updating group_replication_view_change_uuid in the Cluster's metadata...");
 WIPE_STDOUT();
 
@@ -774,9 +774,9 @@ EXPECT_EQ(view_change_uuid, view_change_uuid_md);
 
 // Confirm cluster.rescan() does not warn or act if the target cluster has group_replication_view_change_uuid set
 EXPECT_NO_THROWS(function() { cluster.rescan(); });
-EXPECT_OUTPUT_NOT_CONTAINS("NOTE: The Cluster's group_replication_view_change_uuid is not set");
+EXPECT_OUTPUT_NOT_CONTAINS("NOTE: The Cluster's group_replication_view_change_uuid is not set.");
 EXPECT_OUTPUT_NOT_CONTAINS("Generating and setting a value for group_replication_view_change_uuid...");
-EXPECT_OUTPUT_NOT_CONTAINS("WARNING: The Cluster must be completely taken OFFLINE and restarted (dba.rebootClusterFromCompleteOutage()) for the settings to be effective");
+EXPECT_OUTPUT_NOT_CONTAINS("NOTE: The Cluster must be completely taken OFFLINE and restarted (dba.rebootClusterFromCompleteOutage()) for the settings to be effective");
 EXPECT_OUTPUT_NOT_CONTAINS("Updating group_replication_view_change_uuid in the Cluster's metadata...");
 
 //@<> Bug #33235502 Check for incorrect recovery accounts and fix them