Skip to content

Use LIFO for returning/retrieving connections from the pool #2085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Use LIFO for returning/retrieving connections from the pool #2085

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c35b66c
Use LIFO for connection retrieval from pool
4ver Aug 16, 2018
3ae2c41
Add roundRobinConnectionCycling option
4ver Aug 16, 2018
6172ea6
Fix for Node 0.6
4ver Aug 16, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Fix for Node 0.6
  • Loading branch information
@4ver
4ver committed Aug 16, 2018
commit 6172ea68c73f54d498d6b7dab890b12f98bf5e6b
2 changes: 1 addition & 1 deletion test/unit/pool/test-connection-cycling-lifo.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,5 @@ server.listen(common.fakeServerPort, function (err) {
done();
});
};
Array.apply(null, {length: numberOfConnections}).map(createIndexedConnection);
Array.apply(null, Array(numberOfConnections)).map(createIndexedConnection);
});
2 changes: 1 addition & 1 deletion test/unit/pool/test-connection-cycling-round-robin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,5 +43,5 @@ server.listen(common.fakeServerPort, function (err) {
done();
});
};
Array.apply(null, {length: numberOfConnections}).map(createIndexedConnection);
Array.apply(null, Array(numberOfConnections)).map(createIndexedConnection);
});