Skip to content

Add support for 'mysql_clear_password - continued #2327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
+114 −5
Open

Add support for 'mysql_clear_password - continued #2327

Changes from 1 commit
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
8688bea
change handling of user-set flags
nmggithub May 29, 2019
cced61f
add support for 'mysql_clear_password' auth plugin
nmggithub May 29, 2019
fe3cef2
add tests
nmggithub May 31, 2019
9fb9c88
Delete test as it only passes for specific servers
nmggithub Jun 3, 2019
56428eb
Add unit test
ZJONSSON Mar 28, 2020
6a785ae
Ensure that `mysql_clear_password` is never used over insecure connec…
ZJONSSON Mar 28, 2020
65368e4
Rename this._tls to this.secureConnection and fold into options
ZJONSSON Mar 29, 2020
810dfb0
* Revert generic SSL flag
ZJONSSON Mar 29, 2020
63f6bfe
Revert flag merging to use blacklist
ZJONSSON Mar 29, 2020
6753e1b
use safe-buffer (compatibility with older node versions)
ZJONSSON Mar 29, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Revert flag merging to use blacklist
  • Loading branch information
@ZJONSSON
ZJONSSON committed Mar 29, 2020
commit 63f6bfe6e5679bee5fc43a64267cc526087edddd
2 changes: 1 addition & 1 deletion lib/ConnectionConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ ConnectionConfig.mergeFlags = function mergeFlags(defaultFlags, userFlags) {

// Merge the new flags
for (var flag in newFlags) {
if (allFlags[flag] !== newFlags[flag]) {
if (allFlags[flag] !== false) {
allFlags[flag] = newFlags[flag];
}
}
Expand Down