Skip to content

Change UNKNOWN_CODE_PLEASE_REPORT to identify uknown code #2516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Change UNKNOWN_CODE_PLEASE_REPORT to identify uknown code
Changes UNKNOWN_CODE_PLEASE_REPORT to include packet.errno in it.

This makes it easier to identify what the code is even if the code is not yet supported:

```
(node:1) UnhandledPromiseRejectionWarning: Error: UNKNOWN_CODE_PLEASE_REPORT: Query execution was interrupted, query_timeout exceeded
```
  • Loading branch information
glensc committed Sep 15, 2021
commit 54fb24aafc83dedeae5e3a7ec56e64eb16c15ad6
2 changes: 1 addition & 1 deletion lib/protocol/sequences/Sequence.js
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ Sequence.prototype.hasErrorHandler = function() {

Sequence.prototype._packetToError = function(packet) {
var code = ErrorConstants[packet.errno] || 'UNKNOWN_CODE_PLEASE_REPORT';
var err = new Error(code + ': ' + packet.message);
var err = new Error(code + '[' + packet.errno + ']: ' + packet.message);
err.code = code;
err.errno = packet.errno;

Expand Down