Skip to content

Use WHATWG URL parsing, if available, instead of url.parse #2564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Use WHATWG URL parsing, if available, instead of url.parse #2564

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
4bda23e
Use WHATWG URL parsing, if available, instead of url.parse
dresende Nov 21, 2023
e909c09
Fix connection config parsing
dresende Nov 21, 2023
2e2a156
test: fix password encoding test when using WHATWG URL
dresende Nov 21, 2023
70b1be8
Fix connection config password node being decoded if necessary
dresende Nov 21, 2023
d1b2511
test: rolls back previous change, not needed anymore
dresende Nov 21, 2023
6725ac8
Implement a permissive decodeURIComponent
dresende Nov 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
test: rolls back previous change, not needed anymore
  • Loading branch information
@dresende
dresende committed Nov 21, 2023
commit d1b2511ec9dbb11ef3c687306ea67997d1bf14b9
3 changes: 1 addition & 2 deletions test/unit/test-ConnectionConfig.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ var Crypto = require('crypto');
var test = require('utest');
var assert = require('assert');
var ConnectionConfig = common.ConnectionConfig;
var usesWhatwgUrl = (typeof URL == 'function' && typeof URL.prototype == 'object');

test('ConnectionConfig#Constructor', {
'takes user,pw,host,port,db from url string': function() {
Expand All @@ -24,7 +23,7 @@ test('ConnectionConfig#Constructor', {
assert.equal(config.host, 'myhost');
assert.equal(config.port, 3333);
assert.equal(config.user, 'myuser');
assert.equal(config.password, usesWhatwgUrl ? 'my%3Apass' : 'my:pass');
assert.equal(config.password, 'my:pass');
assert.equal(config.database, 'mydb');
},

Expand Down