Switch from zenodo.json to CITATION.cff, add contributors #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM. Thanks! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #237 +/- ##
==========================================
+ Coverage 95.15% 95.38% +0.22%
==========================================
Files 28 28
Lines 2933 2948 +15
==========================================
+ Hits 2791 2812 +21
+ Misses 142 136 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
It's nice of you to include me in the citation! My info there is right. But I also modified exactly 2 lines of code so I don't think you need to credit me. I'll leave that up to you. |
|
Thanks for putting this together @effigies ! It looks great to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We haven't been updating contributors properly. I think it will generally be easier to have people add themselves to CITATION.cff when they do contribute.
There isn't a distinction between creators and contributors, so that's one downside here.
Please confirm your ORCIDs, names and affiliations: @bpinsard @jbanusco @mvdoc @jmarabotto @feilong @Shotgunosine @shnizzedy @coryshain