Skip to content

chore(lint): use console[xyz] over process #274

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2025
Merged

Conversation

avivkeller
Copy link
Member

If all of these are sent to stdout and the user pipes the output using >, the lint errors will be included. Instead, the outputs should be directed appropriately based on the context, right?

@avivkeller avivkeller requested a review from a team as a code owner May 17, 2025 22:00
Copy link
Member

@AugustinMauroy AugustinMauroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM just maybe on improvement

@avivkeller avivkeller requested review from flakey5 and removed request for flakey5 May 20, 2025 11:58
@avivkeller
Copy link
Member Author

@flakey5 please re-review

@avivkeller avivkeller merged commit 16a36c6 into main May 22, 2025
7 checks passed
@avivkeller avivkeller deleted the chore/use-console-log branch May 22, 2025 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants