-
Notifications
You must be signed in to change notification settings - Fork 9
chore(test): organize test folders #307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #307 +/- ##
==========================================
- Coverage 41.24% 39.78% -1.47%
==========================================
Files 94 83 -11
Lines 7092 6905 -187
Branches 211 208 -3
==========================================
- Hits 2925 2747 -178
+ Misses 4164 4155 -9
Partials 3 3 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel this PR is doing way too many things at the same time:
- it is adding a new linter rule
- moving tests to different folders
- add new tests
- update docs
It becomes harder to review; Would you mind breaking up these changes? Not needed if this is too much effort; It is more of a nit than anything else but also a general recommendation.
Sorry! The main goal of this PR was to increase coverage, I'll split it up, I was a bit overzealous. |
All fine, we all do this from time to time 🙈 (myself included!) |
6cf087d
to
9cda439
Compare
Codecov is failing because ESLint is not ignored from coverage, once this lands, I'll give us some wiggle-room via the additional tests, then we can land that and Codecov should be happy. |
Can you update the PR title to reflect on the contents of the PR? Seems to be adding new tests and moving tests. Or maybe Git is just not recognising some of the moves? |
It's not really "adding" tests, it's splitting a |
be74376
to
b56c540
Compare
Alrighty, I'm +1 to fast tracking this if needed. |
Awesome! I'll write some more tests and open a follow up ASAP |
This PR organizes our tests via the same convention as the website
Fixes #308