Skip to content

chore(test): organize test folders #307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 4, 2025
Merged

Conversation

avivkeller
Copy link
Member

@avivkeller avivkeller commented Jun 4, 2025

This PR organizes our tests via the same convention as the website

Fixes #308

@Copilot Copilot AI review requested due to automatic review settings June 4, 2025 19:02
@avivkeller avivkeller requested a review from a team as a code owner June 4, 2025 19:02
Copilot

This comment was marked as outdated.

Copy link

codecov bot commented Jun 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 39.78%. Comparing base (42bbad6) to head (b56c540).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
eslint.config.mjs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #307      +/-   ##
==========================================
- Coverage   41.24%   39.78%   -1.47%     
==========================================
  Files          94       83      -11     
  Lines        7092     6905     -187     
  Branches      211      208       -3     
==========================================
- Hits         2925     2747     -178     
+ Misses       4164     4155       -9     
  Partials        3        3              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@avivkeller

This comment was marked as outdated.

Copy link
Member

@ovflowd ovflowd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel this PR is doing way too many things at the same time:

  • it is adding a new linter rule
  • moving tests to different folders
  • add new tests
  • update docs

It becomes harder to review; Would you mind breaking up these changes? Not needed if this is too much effort; It is more of a nit than anything else but also a general recommendation.

@avivkeller
Copy link
Member Author

Sorry! The main goal of this PR was to increase coverage, I'll split it up, I was a bit overzealous.

@ovflowd
Copy link
Member

ovflowd commented Jun 4, 2025

Sorry! The main goal of this PR was to increase coverage, I'll split it up, I was a bit overzealous.

All fine, we all do this from time to time 🙈 (myself included!)

@avivkeller avivkeller changed the title chore(coverage, docs): improve coverage, and add testing documentation chore(test): organize test folders Jun 4, 2025
@avivkeller avivkeller force-pushed the chore/coverage-and-docs branch from 6cf087d to 9cda439 Compare June 4, 2025 21:04
@avivkeller avivkeller requested a review from ovflowd June 4, 2025 21:05
@avivkeller
Copy link
Member Author

Codecov is failing because ESLint is not ignored from coverage, once this lands, I'll give us some wiggle-room via the additional tests, then we can land that and Codecov should be happy.

@ovflowd
Copy link
Member

ovflowd commented Jun 4, 2025

Can you update the PR title to reflect on the contents of the PR? Seems to be adding new tests and moving tests. Or maybe Git is just not recognising some of the moves?

@avivkeller
Copy link
Member Author

Can you update the PR title to reflect on the contents of the PR? Seems to be adding new tests and moving tests. Or maybe Git is just not recognising some of the moves?

It's not really "adding" tests, it's splitting a utils.test.mjs into /__test__/<utility>.test.mjs, which is the convention we use, rather than a single test file for a whole directory.

@avivkeller avivkeller force-pushed the chore/coverage-and-docs branch from be74376 to b56c540 Compare June 4, 2025 21:28
@ovflowd
Copy link
Member

ovflowd commented Jun 4, 2025

Alrighty, I'm +1 to fast tracking this if needed.

@avivkeller avivkeller merged commit aff9339 into main Jun 4, 2025
8 of 10 checks passed
@avivkeller avivkeller deleted the chore/coverage-and-docs branch June 4, 2025 21:35
@avivkeller
Copy link
Member Author

Awesome! I'll write some more tests and open a follow up ASAP

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misorganized Tests Folders
2 participants