Skip to content

fix(DataTag): add global #7804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 1, 2025
Merged

fix(DataTag): add global #7804

merged 1 commit into from
Jun 1, 2025

Conversation

avivkeller
Copy link
Member

This type was missing from HeadingMetataEntry, so I didn't know to add it.

See nodejs/api-docs-tooling#289 for the fix PR.

@Copilot Copilot AI review requested due to automatic review settings June 1, 2025 14:12
@avivkeller avivkeller requested a review from a team as a code owner June 1, 2025 14:12
Copy link

vercel bot commented Jun 1, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
nodejs-org ✅ Ready (Inspect) Visit Preview Jun 1, 2025 2:13pm

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds support for a new “global” tag to the DataTag component and its associated UI display.

  • Extends DataTagProps and symbolMap with a “global” variant
  • Updates Storybook stories to include the global tag
  • Adds CSS styling for the global tag

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/ui-components/Common/DataTag/index.tsx Added 'global' to DataTagProps and symbolMap
packages/ui-components/Common/DataTag/index.stories.tsx Included 'global' in the story array
packages/ui-components/Common/DataTag/index.module.css Defined styling for the .global class
Comments suppressed due to low confidence (2)

packages/ui-components/Common/DataTag/index.stories.tsx:23

  • Elements rendered in a list should include a unique key prop to avoid React warnings. Consider adding key={${kind}-${size}} to the <div>.
<div

packages/ui-components/Common/DataTag/index.tsx:14

  • Add a unit test for the new 'global' DataTag variant to verify it renders the correct symbol and applies the expected styling.
| 'global'

Copy link

codecov bot commented Jun 1, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.46%. Comparing base (79dc769) to head (48bdfa7).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7804   +/-   ##
=======================================
  Coverage   75.46%   75.46%           
=======================================
  Files         101      101           
  Lines        8309     8309           
  Branches      218      218           
=======================================
  Hits         6270     6270           
  Misses       2037     2037           
  Partials        2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

github-actions bot commented Jun 1, 2025

Lighthouse Results

URL Performance Accessibility Best Practices SEO Report
/en 🟢 98 🟢 100 🟢 100 🟢 91 🔗
/en/about 🟢 100 🟢 100 🟢 100 🟠 82 🔗
/en/about/previous-releases 🟢 99 🟢 100 🟢 100 🟠 83 🔗
/en/download 🟢 97 🟢 100 🟢 100 🟢 91 🔗
/en/blog 🟢 100 🟢 100 🟢 96 🟢 92 🔗

@avivkeller avivkeller enabled auto-merge June 1, 2025 14:18
@avivkeller avivkeller added this pull request to the merge queue Jun 1, 2025
Merged via the queue into main with commit 71be084 Jun 1, 2025
22 of 24 checks passed
@avivkeller avivkeller deleted the fix/datatag/missing-type branch June 1, 2025 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track Fast Tracking PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants