-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
fix(DataTag): add global #7804
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(DataTag): add global #7804
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds support for a new “global” tag to the DataTag component and its associated UI display.
- Extends DataTagProps and symbolMap with a “global” variant
- Updates Storybook stories to include the global tag
- Adds CSS styling for the global tag
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
File | Description |
---|---|
packages/ui-components/Common/DataTag/index.tsx | Added 'global' to DataTagProps and symbolMap |
packages/ui-components/Common/DataTag/index.stories.tsx | Included 'global' in the story array |
packages/ui-components/Common/DataTag/index.module.css | Defined styling for the .global class |
Comments suppressed due to low confidence (2)
packages/ui-components/Common/DataTag/index.stories.tsx:23
- Elements rendered in a list should include a unique
key
prop to avoid React warnings. Consider addingkey={
${kind}-${size}}
to the<div>
.
<div
packages/ui-components/Common/DataTag/index.tsx:14
- Add a unit test for the new
'global'
DataTag variant to verify it renders the correct symbol and applies the expected styling.
| 'global'
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #7804 +/- ##
=======================================
Coverage 75.46% 75.46%
=======================================
Files 101 101
Lines 8309 8309
Branches 218 218
=======================================
Hits 6270 6270
Misses 2037 2037
Partials 2 2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Lighthouse Results
|
This type was missing from
HeadingMetataEntry
, so I didn't know to add it.See nodejs/api-docs-tooling#289 for the fix PR.