Skip to content

Conversation

@xiehan
Copy link

@xiehan xiehan commented Jun 17, 2016

No description provided.

@justinbach
Copy link

I'm all for the change from 2 to 4 tabs.

I think that the other rule is perhaps overly restrictive, because there are situations where declaring local variables inside of case conditions makes the code more readable. Perhaps we can modify the language to require curly braces around the block only when declaring branch-local variables, and otherwise not using them?

@xiehan
Copy link
Author

xiehan commented Oct 3, 2016

@justinbach If you're okay with starting to enforce the second case, then it's fine with me. My biggest issue is that we already have a ton of code in place not enforcing that rule (especially in WWW, with all of the reducers), and it's useless to have rules that we're not going to enforce ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants