[nrf noup] drivers: i2s: nrfx: Align to driver without cb #3401
+82
−120
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaz1-nordic
requested review from
magp-nordic,
masz-nordic,
mif1-nordic,
mstasiaknordic and
nika-nordic
jaz1-nordic
force-pushed
the
nrfx-8446_nrfx_i2s_without_cb
branch
from
9cfe696 to
abc285d
Compare
magp-nordic
reviewed
Oct 16, 2025
There was a problem hiding this comment.
It looks like you missed removing setting ENABLED symbols for nrfx, like here: 522510f
jaz1-nordic
force-pushed
the
nrfx-8446_nrfx_i2s_without_cb
branch
3 times, most recently
from
ff73998 to
6ed8419
Compare
jaz1-nordic
force-pushed
the
nrfx-8446_nrfx_i2s_without_cb
branch
3 times, most recently
from
800409e to
564c2bd
Compare
magp-nordic
approved these changes
Oct 17, 2025
|
@jaz1-nordic did you create an upstream draft PR? Commits have tags [nrf noup] instead of [nrf fromlist] |
jaz1-nordic
force-pushed
the
nrfx-8446_nrfx_i2s_without_cb
branch
from
564c2bd to
a5c786d
Compare
Remove I2S instances from Kconfig files. Upstream PR #: 97915 Signed-off-by: Jakub Zymelka <[email protected]>
Align SHIM to nrfx_i2s driver version without cb. Upstream PR #: 97915 Signed-off-by: Jakub Zymelka <[email protected]>
jaz1-nordic
force-pushed
the
nrfx-8446_nrfx_i2s_without_cb
branch
from
a5c786d to
704cfe4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Align SHIM to nrfx_i2s driver version without cb.