Skip to content

Conversation

@PerMac
Copy link
Contributor

@PerMac PerMac commented Jan 31, 2022

Bring back parallel execution to the clang action. In the upstream
they went to use a single dedicated powerfull agent to run this. We
need to keep this as we have to base on agents available in github's
cloud.

Signed-off-by: Maciej Perkowski [email protected]

@PerMac
Copy link
Contributor Author

PerMac commented Jan 31, 2022

The current execution of clang action takes up to 100m for PRs requiring a full set of tests. With this mod it should go <30 min. I tested this mod on my fork of sdk-zephyr and PR triggering the full scope of tests (change in the manifest). PerMac#20
The build was triggered on 5 agents in parallel and the scope was properly divided into subsets. The purposely introduced error in hello_word sample was caught in one of the subsets.

Copy link
Contributor

@nvlsianpu nvlsianpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This downstream path is worth to be added. The Patch is not complex and gives a lot of timing improvement. Also command-line changes here look fine.

Bring back parallel execution to the clang action. In the upstream
they went to use a single dedicated powerfull agent to run this. We
need to keep this as we have to base on agents available in github's
cloud.

Signed-off-by: Maciej Perkowski <[email protected]>
@PerMac PerMac force-pushed the pr/parallel_clang branch from 9a6dd74 to 2e1dbc3 Compare February 2, 2022 14:25
@PerMac PerMac merged commit f0876d4 into nrfconnect:main Feb 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants