Skip to content

Add bad code #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add bad code #8

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f36655a
Add bad code
austenstone Nov 2, 2023
b5f32f8
🦵
felickz Apr 12, 2024
16cbc75
🦵🦵
felickz Apr 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions advanced-security-python/server/routes.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,18 @@

from flask import request, render_template, make_response

from server.webapp import flaskapp, cursor
from server.models import Book


@flaskapp.route('/')
def index():
name = request.args.get('name')
author = request.args.get('author')
read = bool(request.args.get('read'))

if name:
cursor.execute(
"SELECT * FROM books WHERE name LIKE '%" + name + "%'"

Check failure

Code scanning / CodeQL

SQL query built from user-controlled sources

This SQL query depends on a [user-provided value](1).
)
cursor.execute(
"SELECT * FROM books WHERE name LIKE '%" + name + "%'"
)
Expand Down