[FIX] hr_holidays: fix search on leave type #4865
Draft
+57
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding-hkafe, it needs to be retargeted before it can be merged. |
mepe-odoo
requested changes
Nov 5, 2025
mepe-odoo
left a comment
mepe-odoo
left a comment
There was a problem hiding this comment.
Hello your commit message is not correct :D
HashemKhaled
force-pushed
the
master-hr-onboarding-fix_leave_type_search-hkafe
branch
from
8370a8c to
d8fbc33
Compare
Author
Hello, thanks for pointing me out to this! I thought we do not need to do it for small changes 🫣 |
mepe-odoo
requested changes
Nov 6, 2025
mepe-odoo
left a comment
mepe-odoo
left a comment
There was a problem hiding this comment.
you also need to add a test :D as it's a bugfix task :)
HashemKhaled
force-pushed
the
master-hr-onboarding-fix_leave_type_search-hkafe
branch
from
d8fbc33 to
1df0172
Compare
arpi-odoo
requested changes
Nov 7, 2025
Comment on lines
138
to
188
| test_cases = [ | ||
| # (operator, value, expected_leave_type_1, expected_leave_type_2, description_type_1, description_type_2) | ||
| ( | ||
| ">", | ||
| 0, | ||
| True, | ||
| True, | ||
| "should be in the result as it has remaining leaves", | ||
| "should be in the result since it does not require allocation", | ||
| ), | ||
| ( | ||
| "=", | ||
| 0, | ||
| False, | ||
| True, | ||
| "should not be in the result as it has remaining leaves != 0", | ||
| "should be in the result since it does not require allocation", | ||
| ), | ||
| ( | ||
| ">", | ||
| 4, | ||
| False, | ||
| True, | ||
| "should not be in the result", | ||
| "should be in the result since it does not require allocation", | ||
| ), | ||
| ] | ||
|
|
||
| for ( | ||
| operator, | ||
| value, | ||
| expected_type_1, | ||
| expected_type_2, | ||
| description_type_1, | ||
| description_type_2, | ||
| ) in test_cases: | ||
| result = ( | ||
| self.env["hr.leave.type"] | ||
| .with_context(employee_id=employee.id) | ||
| .search([("virtual_remaining_leaves", operator, value)]) | ||
| ) | ||
| self.assertIn( | ||
| leave_type_1, result, f"Leave Type 1 {description_type_1}", | ||
| ) if expected_type_1 else self.assertNotIn( | ||
| leave_type_1, result, f"Leave Type 1 {description_type_1}", | ||
| ) | ||
| self.assertIn( | ||
| leave_type_2, result, f"Leave Type 2 {description_type_2}", | ||
| ) if expected_type_2 else self.assertNotIn( | ||
| leave_type_2, result, f"Leave Type 2 {description_type_2}", | ||
| ) |
There was a problem hiding this comment.
Having a loop here seems like a good idea because it could be repetitive but for testing, it is actually best to repeat and be more verbose to have a more readable and maintainable test.
Author
There was a problem hiding this comment.
Okay, I thought parameterizing the tests would make more sense to avoid repetition, but I am also aligned with you that being more verbose in tests is better.
**Steps to reproduce:** Navigate to Time Off >> Configuration >> Time Off Types >> Open any type, navigate to the Smart button Time Off >> Click on New >> Time Off Type Leads to an error. Reference Video: https://drive.google.com/file/d/1vi_apL24Km5tSomQtwcTArqqWvrBR5ni/view?usp=drive_link **Reason:** The `op` function is a comparison operator function that expects two values to compare and we are only passing to it `leave_type.virtual_remaining_leaves` parameter. **Solution:** Added the missing `value` parameter. Task: 5238200
HashemKhaled
force-pushed
the
master-hr-onboarding-fix_leave_type_search-hkafe
branch
from
1df0172 to
125e66c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to reproduce:
Navigate to Time Off >> Configuration >> Time Off Types >> Open any type, navigate to the Smart button Time Off >> Click on New >> Time Off Type
Leads to an error. [Reference Video]
Reason:
The
opfunction is a comparison operator function that expects two values to compare and we are only passing to itleave_type.virtual_remaining_leavesparameter.Solution:
Added the missing
valueparameter.Task: 5238200