[FIX]: hr_holidays: fix time off type error in time off form view #4869
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR targets the un-managed branch odoo-dev/odoo:master-hr-onboarding-moaln, it needs to be retargeted before it can be merged. |
Mohamed-Khaled308
force-pushed
the
master-hr-onboarding-time_off_type_bug-moaln
branch
from
eb044b7 to
ae49b9c
Compare
mepe-odoo
requested changes
Nov 6, 2025
mepe-odoo
left a comment
mepe-odoo
left a comment
There was a problem hiding this comment.
thanks for your work :D
As It's a bug fix task you need to add a test (this test need to fail before your fix and pass after)
Also in your commit message you need to add the step to reproduce the issue :D
But the fix seems good 👀
Mohamed-Khaled308
force-pushed
the
master-hr-onboarding-time_off_type_bug-moaln
branch
from
ae49b9c to
c44c21b
Compare
1. Go to **Time Off > Configuration > Time Off Types**. 2. Open a type and click the "Time Off" smart button. 3. Click **New**. 4. An error appears. [[Reference Video](https://drive.google.com/file/d/1vi_apL24Km5tSomQtwcTArqqWvrBR5ni/view)] In the `_search_virtual_remaining_leaves` method, the code tries to use an operator (like `>`) to compare the `virtual_remaining_leaves`. This operator requires **two** arguments to work. However, the code was only passing **one** argument, missing the `value` to compare against. This caused the "expects 2 arguments" error. Passed the missing `value` to the operator call so the comparison can be completed correctly. Task: 5241685
Mohamed-Khaled308
force-pushed
the
master-hr-onboarding-time_off_type_bug-moaln
branch
from
c44c21b to
0495318
Compare
Author
|
Thank you very much for your review! |
mepe-odoo
requested changes
Nov 7, 2025
| self.assertFalse(leave_types, "Got valid leaves outside vaild period") | ||
|
|
||
| def test_search_virtual_remaining_leaves(self): | ||
| leave_types = self.env['hr.leave.type']._search_virtual_remaining_leaves('>', 0) |
There was a problem hiding this comment.
you should call the regular search method on the field virtual_remaining_leaves :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to Reproduce
[Reference Video]
Reason
In the
_search_virtual_remaining_leavesmethod, the code tries to use an operator (like>) to compare thevirtual_remaining_leaves.This operator requires two arguments to work. However, the code was only passing one argument, missing the
valueto compare against. This caused the "expects 2 arguments" error.Solution
Passed the missing
valueto the operator call so the comparison can be completed correctly.Task: 5241685