include/json/value.h is changed #1461
Conversation
include/json/value.h
Outdated
| #ifndef JSON_H_INCLUDED | ||
| #define JSON_H_INCLUDED | ||
| #ifndef JSON_VALUE_H_INCLUDED | ||
| #define JSON_VALUE_H_INCLUDED |
There was a problem hiding this comment.
We need to change the comment at the bottom to match.
There was a problem hiding this comment.
Hi, I have been change my comment.
There was a problem hiding this comment.
great. push your update?
There was a problem hiding this comment.
Sorry, This is my first contribution to an open source project. Should I have to write such a message "fix: I fix include/json/value.h and my comment" in the below comment section and press the close pull request button for pushing?
There was a problem hiding this comment.
or should I add value.h again in my local area, write the comment correctly and push it again?
There was a problem hiding this comment.
i meant the C++ comment at the bottom of the source file. It's still referring to the old macro name.
include/json/value.h is changed