Skip to content

chore(internal): configure releases #129

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 16, 2025
Merged

Conversation

meorphis
Copy link
Collaborator

configures openai-ruby releases similar to how we have them set-up for other languages, e.g. https://github.com/openai/openai-node/blob/next/.github/workflows/create-releases.yml

@meorphis meorphis requested a review from a team as a code owner April 16, 2025 22:35
@meorphis meorphis changed the base branch from main to next April 16, 2025 22:35
@meorphis meorphis requested a review from ms-jpq April 16, 2025 22:35
Copy link
Collaborator

@ms-jpq ms-jpq left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

edit: actually nevermind

name: Create releases
on:
schedule:
- cron: '0 5 * * *' # every day at 5am UTC
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure if we need to publish at 5 AM every day haha, but everything else looks sound!

@ms-jpq ms-jpq self-requested a review April 16, 2025 22:48
@@ -1,7 +1,5 @@
name: Create releases
on:
schedule:
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: no biggie, but having a manual release trigger wouldnt hurt!

I think that's what the cron job in the python-sdk functionally does actually

@meorphis meorphis merged commit 46d0a56 into next Apr 16, 2025
2 checks passed
@meorphis meorphis deleted the meorphis/configure-releases branch April 16, 2025 23:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants