8357470: src/java.base/share/classes/sun/security/util/Debug.java implement the test for args.toLowerCase

[myankelev]

• added an automated mixed case option
• using multithreading now
• added logs for simpler debug
• added missing -Djava.security.auth.debug coverage

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8357470: src/java.base/share/classes/sun/security/util/Debug.java implement the test for args.toLowerCase (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25391/head:pull/25391
$ git checkout pull/25391

Update a local copy of the PR:
$ git checkout pull/25391
$ git pull https://git.openjdk.org/jdk.git pull/25391/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25391

View PR using the GUI difftool:
$ git pr show -t 25391

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25391.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back myankelevich! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@myankelev The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 03: Full - Incremental (df17d7de)
• 02: Full - Incremental (f23f2545)
• 01: Full (4f36b0f6)
• 00: Full (09a1ad5d)

[openjdk]

@myankelev this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8357470
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

[bridgekeeper]

@myankelev This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[coffeys]

As the original contributor of this test case, it's nice to see the speed up via use of ExecutorService.

The upper case and lower case property tests are somewhat questionable IMO. One or two lines of test code would suffice but now we have a lot of noise distracting from the original intent of the test code. One could argue that every system property in the JDK could be subject to the same uppercase/lower case testing but such tests don't exist. A few lines of test code can easily verify behavior. Anything else enters the fuzzy logic testing approach. Hope it's not a pattern that new tests have to adopt.

[myankelev]

As the original contributor of this test case, it's nice to see the speed up via use of ExecutorService.

The upper case and lower case property tests are somewhat questionable IMO. One or two lines of test code would suffice but now we have a lot of noise distracting from the original intent of the test code. One could argue that every system property in the JDK could be subject to the same uppercase/lower case testing but such tests don't exist. A few lines of test code can easily verify behavior. Anything else enters the fuzzy logic testing approach. Hope it's not a pattern that new tests have to adopt.

Do you think that keeping it just mixed case would be sufficient? I believe this approach might be too much for other tests, it seems to me like a lot for this one as well

[coffeys]

As the original contributor of this test case, it's nice to see the speed up via use of ExecutorService.
The upper case and lower case property tests are somewhat questionable IMO. One or two lines of test code would suffice but now we have a lot of noise distracting from the original intent of the test code. One could argue that every system property in the JDK could be subject to the same uppercase/lower case testing but such tests don't exist. A few lines of test code can easily verify behavior. Anything else enters the fuzzy logic testing approach. Hope it's not a pattern that new tests have to adopt.

Do you think that keeping it just mixed case would be sufficient? I believe this approach might be too much for other tests, it seems to me like a lot for this one as well

I'd welcome anything that helps reduce the extra code that's being added to test multiple case combinations for a system property. It strikes me as overkill.

[myankelev]

@koushikthirupattur @coffeys brought the cases to mixed case only in order to still test everything, but no going into the testing of the implementation of the toLowerCase()