Skip to content

8357581: [JVMCI] Add HotSpotProfilingInfo #25397

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

dougxc
Copy link
Member

@dougxc dougxc commented May 22, 2025

Graal is adding enhanced logic to detect deoptimization cycles and needs to be able to query a method's decompilation counter (i.e. MethodData::_compiler_counters._nof_decompiles).
This PR adds the HotSpotProfilingInfo interface so that such HotSpot-specific profiling info can be accessed.
The change looks bigger in the GitHub review UI than it really is. I have simply renamed the pre-existing HotSpotProfilingInfo private class as HotSpotProfilingInfoImpl and repurposed the HotSpotProfilingInfo name for the new public interface.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8357581: [JVMCI] Add HotSpotProfilingInfo (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25397/head:pull/25397
$ git checkout pull/25397

Update a local copy of the PR:
$ git checkout pull/25397
$ git pull https://git.openjdk.org/jdk.git pull/25397/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25397

View PR using the GUI difftool:
$ git pr show -t 25397

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25397.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented May 22, 2025

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented May 22, 2025

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8357581: [JVMCI] Add HotSpotProfilingInfo

Reviewed-by: kvn, never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 27 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented May 22, 2025

@dougxc The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@dougxc dougxc marked this pull request as ready for review May 22, 2025 17:59
@openjdk openjdk bot added the rfr Pull request is ready for review label May 22, 2025
@mlbridge
Copy link

mlbridge bot commented May 22, 2025

Webrevs

Copy link
Contributor

@tkrodriguez tkrodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dougxc dougxc changed the title 8357581: [JVMCI] Add ProfilingInfo.getDecompileCount 8357581: [JVMCI] Add HotSpotProfilingInfo May 22, 2025
@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 22, 2025
Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one cosmetic comment about copyright year.

@@ -0,0 +1,243 @@
/*
* Copyright (c) 2012, 2025, Oracle and/or its affiliates. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is one is fine since you copied it from an other file.

@openjdk openjdk bot removed the ready Pull request is ready to be integrated label May 23, 2025
Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label May 23, 2025
@dougxc
Copy link
Member Author

dougxc commented May 23, 2025

Thanks for the reviews.

/integrate

@openjdk
Copy link

openjdk bot commented May 23, 2025

Going to push as commit 2b6b766.
Since your change was applied there have been 28 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label May 23, 2025
@openjdk openjdk bot closed this May 23, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels May 23, 2025
@openjdk
Copy link

openjdk bot commented May 23, 2025

@dougxc Pushed as commit 2b6b766.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

3 participants