-
Notifications
You must be signed in to change notification settings - Fork 5.9k
8357581: [JVMCI] Add HotSpotProfilingInfo #25397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into |
@dougxc This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 27 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
e646c66
to
af7e605
Compare
Webrevs
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one cosmetic comment about copyright year.
src/jdk.internal.vm.ci/share/classes/jdk/vm/ci/hotspot/HotSpotProfilingInfo.java
Outdated
Show resolved
Hide resolved
@@ -0,0 +1,243 @@ | |||
/* | |||
* Copyright (c) 2012, 2025, Oracle and/or its affiliates. All rights reserved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is one is fine since you copied it from an other file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good.
Thanks for the reviews. /integrate |
Going to push as commit 2b6b766.
Your commit was automatically rebased without conflicts. |
Graal is adding enhanced logic to detect deoptimization cycles and needs to be able to query a method's decompilation counter (i.e.
MethodData::_compiler_counters._nof_decompiles
).This PR adds the
HotSpotProfilingInfo
interface so that such HotSpot-specific profiling info can be accessed.The change looks bigger in the GitHub review UI than it really is. I have simply renamed the pre-existing
HotSpotProfilingInfo
private class asHotSpotProfilingInfoImpl
and repurposed theHotSpotProfilingInfo
name for the new public interface.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25397/head:pull/25397
$ git checkout pull/25397
Update a local copy of the PR:
$ git checkout pull/25397
$ git pull https://git.openjdk.org/jdk.git pull/25397/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 25397
View PR using the GUI difftool:
$ git pr show -t 25397
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25397.diff
Using Webrev
Link to Webrev Comment