8349946: Cipher javadoc could describe AEAD reuse better

[koushikthirupattur]

The class documentation in javax.crypto.Cipher could better describe AEAD and reuse. The current class description example is outdated as GCM encryption does not allow resets. The doc should state that reset() may not be possible with some algorithms or providers and that an InvalidAlgorithmParameterException is thrown

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change requires CSR request JDK-8358812 to be approved

Issues

• JDK-8349946: Cipher javadoc could describe AEAD reuse better (Bug - P4)
• JDK-8358812: Cipher javadoc could describe AEAD reuse better (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25399/head:pull/25399
$ git checkout pull/25399

Update a local copy of the PR:
$ git checkout pull/25399
$ git pull https://git.openjdk.org/jdk.git pull/25399/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25399

View PR using the GUI difftool:
$ git pr show -t 25399

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25399.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back koushikthirupattur! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@koushikthirupattur The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[ascarpino]

/csr

[openjdk]

@ascarpino has indicated that a compatibility and specification (CSR) request is needed for this pull request.

@koushikthirupattur please create a CSR request for issue JDK-8349946 with the correct fix version. This pull request cannot be integrated until the CSR request is approved.

[mlbridge]

Webrevs

• 02: Full - Incremental (fcc5baba)
• 01: Full - Incremental (8d8446e3)
• 00: Full (ea320d8a)

[ascarpino]

Line 170 and 171 can be removed as the CC20/Poly1305 RFC isn't referenced anymore