8355379: Annotate lazy fields in java.security @Stable

[koushikthirupattur]

Several classes in the java.security package lazily compute their hash value and store it in a field. These fields can typically be annotated with the @Stable annotation. Many of the current implementations are using -1 as a flag for not computed, this needs to be refactored away.

Here are some examples of such classes: PKCS12Attribute, Timestamp, Certificate, and URICertStoreParameters.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8355379: Annotate lazy fields in java.security @Stable (Enhancement - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25405/head:pull/25405
$ git checkout pull/25405

Update a local copy of the PR:
$ git checkout pull/25405
$ git pull https://git.openjdk.org/jdk.git pull/25405/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25405

View PR using the GUI difftool:
$ git pr show -t 25405

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25405.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back koushikthirupattur! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@koushikthirupattur The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (c2304982)
• 00: Full (17778c5f)

[minborg]

I think we should add tests that seralizes/deserializes objects several times to make sure the hash code works as expected here.

[bridgekeeper]

@koushikthirupattur This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!