8358158: test/jdk/java/io/Console/CharsetTest.java failing with NoClassDefFoundError: jtreg/SkippedException #25601

naotoj · 2025-06-02T21:48:04Z

Fixing a regression caused by the fix to JDK-8356985. Although the fix in CharsetTest was a clean-up and not the gist of the original issue, the change seem to have caused not finding SkippedException at runtime in certain cases. Changing the test to JUnit based so that the offending SkippedException can be replaced with JUnit's Assumptions. Also renamed the test case itself to reflect what's actually tested in it.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8358158: test/jdk/java/io/Console/CharsetTest.java failing with NoClassDefFoundError: jtreg/SkippedException (Bug - P4)

Reviewers

Joe Wang (@JoeWang-Java - Reviewer)
Justin Lu (@justin-curtis-lu - Committer)
Iris Clark (@irisclark - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25601/head:pull/25601
$ git checkout pull/25601

Update a local copy of the PR:
$ git checkout pull/25601
$ git pull https://git.openjdk.org/jdk.git pull/25601/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25601

View PR using the GUI difftool:
$ git pr show -t 25601

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25601.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-06-02T21:48:37Z

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-06-02T21:48:54Z

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8358158: test/jdk/java/io/Console/CharsetTest.java failing with NoClassDefFoundError: jtreg/SkippedException

Reviewed-by: joehw, jlu, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 83 new commits pushed to the master branch:

c382da5: 8358178: Some nsk/jdi tests should be run with includevirtualthreads=y even though they pass without
44d62c8: 8358077: sun.tools.attach.VirtualMachineImpl::checkCatchesAndSendQuitTo on Linux leaks file handles after JDK-8327114
d7e58ac: 8351635: C2 ROR/ROL: assert failed: Long constant expected
... and 80 more: https://git.openjdk.org/jdk/compare/3cc630985d47be6ba4cf991698e999f17dbde203...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2025-06-02T21:49:24Z

@naotoj The following label will be automatically applied to this pull request:

core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-06-02T22:50:34Z

Webrevs

01: Full - Incremental (24ccb0fc)
00: Full (2ce00332)

sendaoYan · 2025-06-03T05:48:30Z

test/jdk/java/io/Console/StdoutEncodingTest.java

+ * @summary Tests if "stdout.encoding" property is reflected in
+ *          Console.charset() method. "expect" command in Windows/Cygwin
+ *          does not work as expected. Ignoring tests on Windows.
+ * @requires (os.family == "linux") | (os.family == "mac")


The previous line say Ignoring tests on Windows., so this line maybe set as

@requires os.family != "windows"

It is true that the intention is to exclude testing on Windows. However, I would like to keep the testing on the platforms which are guaranteed to work, as the test relies on the behavior of the platforms' executable.

jdlib · 2025-06-03T06:13:35Z

test/jdk/java/io/Console/StdoutEncodingTest.java

+        var eval = output.getExitValue();
+        if (eval != 0) {
+            throw new RuntimeException("Test failed. Exit value from 'expect' command: " + eval);
+        }


suggestion: assertEquals(0, eval, "exit value");

Thanks. I replaced it (and other locations applicable) with OutputAnalyzer.shouldHaveExitValue()

justin-curtis-lu

Swapping the jtreg.SkippedException with Assumptions looks good, and we would expect no problems since StdinEncodingTest.java has been passing with a similar Assumptions set up. LGTM.

naotoj · 2025-06-03T23:26:40Z

Thanks for the reviews!
/integrate

openjdk · 2025-06-03T23:28:03Z

Going to push as commit 9c74d54.
Since your change was applied there have been 92 commits pushed to the master branch:

9397535: 8356803: Test TextLayout/TestControls fails on windows & linux: line and paragraph separator show non-zero advance
da49fa5: 8354460: Streaming output for attach API should be turned on by default
704b599: 8358534: Bailout in Conv2B::Ideal when type of cmp input is not supported
... and 89 more: https://git.openjdk.org/jdk/compare/3cc630985d47be6ba4cf991698e999f17dbde203...master

Your commit was automatically rebased without conflicts.

openjdk · 2025-06-03T23:28:10Z

@naotoj Pushed as commit 9c74d54.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

naotoj added 2 commits June 2, 2025 11:00

initial commit

95c3494

Renamed the test

2caf0c4

openjdk bot added the core-libs [email protected] label Jun 2, 2025

args -> classpath

2ce0033

naotoj marked this pull request as ready for review June 2, 2025 22:46

openjdk bot added the rfr Pull request is ready for review label Jun 2, 2025

JoeWang-Java approved these changes Jun 3, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jun 3, 2025

sendaoYan reviewed Jun 3, 2025

View reviewed changes

jdlib reviewed Jun 3, 2025

View reviewed changes

Use of OutputAnalyzer.shouldHaveExitValue() where appropriate

24ccb0f

openjdk bot removed the ready Pull request is ready to be integrated label Jun 3, 2025

justin-curtis-lu approved these changes Jun 3, 2025

View reviewed changes

JoeWang-Java approved these changes Jun 3, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jun 3, 2025

irisclark approved these changes Jun 3, 2025

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Jun 3, 2025

openjdk bot closed this Jun 3, 2025

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 3, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

8358158: test/jdk/java/io/Console/CharsetTest.java failing with NoClassDefFoundError: jtreg/SkippedException #25601

8358158: test/jdk/java/io/Console/CharsetTest.java failing with NoClassDefFoundError: jtreg/SkippedException #25601

Uh oh!

naotoj commented Jun 2, 2025 •

edited by openjdk bot

Loading

Uh oh!

bridgekeeper bot commented Jun 2, 2025

Uh oh!

openjdk bot commented Jun 2, 2025 •

edited

Loading

Uh oh!

openjdk bot commented Jun 2, 2025

Uh oh!

mlbridge bot commented Jun 2, 2025 •

edited

Loading

Uh oh!

sendaoYan Jun 3, 2025 •

edited

Loading

Uh oh!

naotoj Jun 3, 2025

Uh oh!

jdlib Jun 3, 2025

Uh oh!

naotoj Jun 3, 2025

Uh oh!

justin-curtis-lu left a comment

Uh oh!

naotoj commented Jun 3, 2025

Uh oh!

openjdk bot commented Jun 3, 2025

Uh oh!

openjdk bot commented Jun 3, 2025

Uh oh!

Uh oh!

8358158: test/jdk/java/io/Console/CharsetTest.java failing with NoClassDefFoundError: jtreg/SkippedException #25601

8358158: test/jdk/java/io/Console/CharsetTest.java failing with NoClassDefFoundError: jtreg/SkippedException #25601

Uh oh!

Conversation

naotoj commented Jun 2, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Jun 2, 2025

Uh oh!

openjdk bot commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Jun 2, 2025

Uh oh!

mlbridge bot commented Jun 2, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

sendaoYan Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

naotoj Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

jdlib Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

naotoj Jun 3, 2025

Choose a reason for hiding this comment

Uh oh!

justin-curtis-lu left a comment

Choose a reason for hiding this comment

Uh oh!

naotoj commented Jun 3, 2025

Uh oh!

openjdk bot commented Jun 3, 2025

Uh oh!

openjdk bot commented Jun 3, 2025

Uh oh!

Uh oh!

naotoj commented Jun 2, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Jun 2, 2025 •

edited

Loading

mlbridge bot commented Jun 2, 2025 •

edited

Loading

sendaoYan Jun 3, 2025 •

edited

Loading