8358468: Enhance code consistency: java.desktop/macos

[mrserb]

This PR updates the last (!!) remaining platform-specific part of the java.desktop module: macos.
The unix/windows were previously addressed in: #24170 , #24941 and #25439.

Note: Unlike on other platforms, the initial change for macOS caused the "BadSerializationTest" to fail. This test relies on internal details of the Aqua Look & Feel that were previously exposed via serialized data (and already fails on other platforms). Adding the final modifier to the class changes its serialVersionUID, which triggered the failure even on macOS.
To avoid this issue, I have reverted the changes to those internal classes for now, see ff7e64b

To download the diff file and filter only the modified lines you can use the following script:

curl -s https://patch-diff.githubusercontent.com/raw/openjdk/jdk/pull/25607.diff -o d.txt && grep -E '^\+|^\-' d.txt | grep -vE '^\+\+\+|^\-\-\-'

====================================================

The java.desktop module currently lacks proper use of the @Override annotation for methods and the final modifier for classes. While similar changes were previously made in the JavaSound, java.desktop/windows (and some of the classes on demand), these changes are not as critical now due to the new jdk "encapsulation", but they are still useful for improving code consistency.

The public API was not affected so there is no need to worry about a CSR

Note: I will submit additional patches in this area later because:

1. Only lines with @Override and final were modified to keep the diff clear - header dates were not updated (that could be covered by one patch similar to this)
2. I skipped adding @Override for anonymous classes

Any feedback or suggestions are welcome!

Here is a link to a simple diff file, it might be more convenient for reviewing the changes.

The build was successful, and I ran all the open jtreg tests without issues. But it's possible that some closed tests may be affected by these changes. It would be good to verify this by mach5 to ensure everything works as expected.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8358468: Enhance code consistency: java.desktop/macos (Bug - P5)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25607/head:pull/25607
$ git checkout pull/25607

Update a local copy of the PR:
$ git checkout pull/25607
$ git pull https://git.openjdk.org/jdk.git pull/25607/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25607

View PR using the GUI difftool:
$ git pr show -t 25607

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25607.diff

Using Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back serb! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@mrserb The following label will be automatically applied to this pull request:

• client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (ff7e64b6)

[bridgekeeper]

@mrserb This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!