Skip to content

8346886: Add since checker test to jdk.management.jfr #25612

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

nizarbenalla
Copy link
Member

@nizarbenalla nizarbenalla commented Jun 3, 2025

Please review this patch to add a new test to check @since tags in the jdk.management.jfr module.

TIA


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8346886: Add since checker test to jdk.management.jfr (Sub-task - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25612/head:pull/25612
$ git checkout pull/25612

Update a local copy of the PR:
$ git checkout pull/25612
$ git pull https://git.openjdk.org/jdk.git pull/25612/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25612

View PR using the GUI difftool:
$ git pr show -t 25612

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25612.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 3, 2025

👋 Welcome back nbenalla! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 3, 2025

@nizarbenalla This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346886: Add since checker test to jdk.management.jfr

Reviewed-by: egahlin

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 233 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Jun 3, 2025

@nizarbenalla To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@nizarbenalla nizarbenalla marked this pull request as ready for review June 3, 2025 11:10
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 3, 2025
@nizarbenalla
Copy link
Member Author

/label add hotspot-jfr

@openjdk
Copy link

openjdk bot commented Jun 3, 2025

@nizarbenalla
The hotspot-jfr label was successfully added.

@mlbridge
Copy link

mlbridge bot commented Jun 3, 2025

Webrevs

Copy link
Member

@egahlin egahlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks reasonable.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jun 17, 2025
@nizarbenalla
Copy link
Member Author

Thanks Erik

/integrate

@openjdk
Copy link

openjdk bot commented Jun 23, 2025

Going to push as commit 2a70a6d.
Since your change was applied there have been 297 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jun 23, 2025
@openjdk openjdk bot closed this Jun 23, 2025
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jun 23, 2025
@openjdk
Copy link

openjdk bot commented Jun 23, 2025

@nizarbenalla Pushed as commit 2a70a6d.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@nizarbenalla nizarbenalla deleted the add-since-test-jdk.management.jfr branch June 23, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-jfr [email protected] integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants