8346952 : GetGraphicsStressTest.java fails: Native resources unavailable #25619

anass-baya · 2025-06-03T15:32:01Z

Analysis:

We are encountering a race condition in the native code. While retrieving the screen number by calling _getScreenImOn(), the window is disposed. As a result, the AWT-Windows event loop processes the Dispose() call, which triggers UnlinkObjects().
The race condition between the execution paths of these two native methods sometimes causes an exception

Proposed Fix:

While it's possible to introduce a synchronization mechanism, it would not offer any real benefit. The window will be disposed regardless, and we’ll fall back to the default screen. This behavior is already handled in WWindowPeer.java, where a workaround is in place to use the default device when getScreenImOn() returns a non-existent screen number

public void updateGC() {

    int scrn = getScreenImOn();

    if (screenLog.isLoggable(PlatformLogger.Level.FINER)) {
        log.finer("Screen number: " + scrn);
    }

    // get current GD
    Win32GraphicsDevice oldDev = winGraphicsConfig.getDevice();

    Win32GraphicsDevice newDev;
    GraphicsDevice[] devs = GraphicsEnvironment
        .getLocalGraphicsEnvironment()
        .getScreenDevices();

    // Occasionally during device addition/removal getScreenImOn can return
    // a non-existing screen number. Use the default device in this case.
    if (scrn >= devs.length) {
        newDev = (Win32GraphicsDevice) GraphicsEnvironment
            .getLocalGraphicsEnvironment().getDefaultScreenDevice();
    } else {
        newDev = (Win32GraphicsDevice) devs[scrn];
    }
}

Therefore, I propose modifying the native method getScreenImOn to return the default device if the peer is being disposed :

jint AwtWindow::_GetScreenImOn(void *param)
{
...
    jboolean destroyed = JNI_GET_DESTROYED(self);
    if (destroyed == JNI_TRUE){
        env->DeleteGlobalRef(self);
        return AwtWin32GraphicsDevice::GetDefaultDeviceIndex();
    }
...

Tests Summary:

GetGraphicsStressTest (existing test):

    Fails intermittently without the fix

    Consistently passes with the fix

NotifyStressTest (newly added test):

     Consistently fails without the fix

     Consistently passes with the fix

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8346952: GetGraphicsStressTest.java fails: Native resources unavailable (Bug - P4)

Reviewers

Sergey Bylokhov (@mrserb - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/25619/head:pull/25619
$ git checkout pull/25619

Update a local copy of the PR:
$ git checkout pull/25619
$ git pull https://git.openjdk.org/jdk.git pull/25619/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 25619

View PR using the GUI difftool:
$ git pr show -t 25619

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/25619.diff

Using Webrev

Link to Webrev Comment

bridgekeeper · 2025-06-03T15:32:52Z

👋 Welcome back abaya! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-06-03T15:33:54Z

@anass-baya This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346952: GetGraphicsStressTest.java fails: Native resources unavailable

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 229 new commits pushed to the master branch:

4dd1b3a: 8330940: Impossible to create a socket backlog greater than 200 on Windows 8+
240541e: 8359266: Delete the usage of AppContext in the GraphicsDevice
a23de2e: 8360478: libjsig related tier3 jtreg tests fail when asan is configured
... and 226 more: https://git.openjdk.org/jdk/compare/fcb68ea22d020d567c560c7bd5976d3c070d9806...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@mrserb) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

openjdk · 2025-06-03T15:35:11Z

@anass-baya The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

mlbridge · 2025-06-03T15:55:43Z

Webrevs

src/java.desktop/windows/native/libawt/windows/awt_Window.cpp

mrserb · 2025-06-10T23:51:09Z

src/java.desktop/windows/native/libawt/windows/awt_Window.cpp

-        return 0;
-    }
+    // Return the default screen.
+    JNI_CHECK_PEER_GOTO(self, ret);


I suggest reordering it slightly - this pattern is commonly used in most cases where JNI_CHECK_PEER_GOTO is used:

result...; AwtWindow *window = NULL; PDATA pData; JNI_CHECK_PEER_GOTO(self, ret); window = (AwtWindow *)pData;

I still suggest this order.

Also, please add the new bug ID to the GetGraphicsStressTest.
btw I'm still looking into the new test - it always passes for me. Can we tweak it to reproduce the bug more reliably?

I cant reproduce it locally.
I can see it only on CI 20/20 with the new test and 2/20 with the old one

what is the stack trace when the new test fails?

the same stack as the old test. However let me try to enhance it and come back to you

Hello @mrserb,
I've enhanced the new test. It now reproduces the issue consistently (5/5) locally, but only intermittently (6/20) on CI.
Can we proceed like that ?

Hello @mrserb,
What do you think about the test? Does it look good to you?
KR,

looking into it

It is unclear from the diff, but does the PDATA pData have additional space at the beginning?

Yes. it's handled now

src/java.desktop/windows/native/libawt/windows/awt_Window.cpp

mrserb · 2025-06-23T23:05:54Z

test/jdk/java/awt/Frame/NotifyStressTest/NotifyStressTest.java

+        Thread thread1 = new Thread(() -> {
+            for (int i = 0; i < 10; i++) {
+                f.removeNotify();
+                f.addNotify();


Note that we call addNotify last, so the frame will not be disposed at the end of the test.
btw, I cannot reproduce the bug even with the updated test. If you look at the stack trace, it seems the error comes from displayChanged, which is not triggered by the test itself

you can use this test:

/* * Copyright Amazon.com Inc. or its affiliates. All Rights Reserved. * DO NOT ALTER OR REMOVE COPYRIGHT NOTICES OR THIS FILE HEADER. * * This code is free software; you can redistribute it and/or modify it * under the terms of the GNU General Public License version 2 only, as * published by the Free Software Foundation. * * This code is distributed in the hope that it will be useful, but WITHOUT * ANY WARRANTY; without even the implied warranty of MERCHANTABILITY or * FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License * version 2 for more details (a copy is included in the LICENSE file that * accompanied this code). * * You should have received a copy of the GNU General Public License version * 2 along with this work; if not, write to the Free Software Foundation, * Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA. * * Please contact Oracle, 500 Oracle Parkway, Redwood Shores, CA 94065 USA * or visit www.oracle.com if you need additional information or have any * questions. */ import java.awt.Window; /** * @test * @bug 8346952 * @key headful */ public final class BogusFocusableWindowState { public static void main(String[] args) { Window frame = new Window(null) { @Override public boolean getFocusableWindowState() { removeNotify(); return true; } }; try { frame.pack(); frame.setVisible(true); } finally { frame.dispose(); } } }

mrserb · 2025-06-26T21:35:23Z

test/jdk/java/awt/Frame/BogusFocusableWindowState/BogusFocusableWindowState.java

+ * @key headful
+ */
+
+public final class BogusFocusableWindowState {


please split the long line to 80 chars, also the empty line above is not really necessary.

hello @mrserb,
Of course, it's done. Thank you.
For my proposed test, it does trigger the same exception call stack.
However, yours is better. The reproduction frequency with it is 20/20.

anass-baya · 2025-06-30T04:35:11Z

/integrate

openjdk · 2025-06-30T04:35:50Z

@anass-baya
Your change (at version e458e6e) is now ready to be sponsored by a Committer.

anass-baya added 3 commits June 3, 2025 16:16

Add Test for JDK-8346952

c084cc8

Return the default device if the peer is beeing disposed

d3f4ec6

Update copyright

ba8d753

openjdk bot added the client [email protected] label Jun 3, 2025

remove extra-space

d3cfe00

anass-baya changed the title ~~Draft 8346952 : GetGraphicsStressTest.java fails: Native resources unavailable~~ 8346952 : GetGraphicsStressTest.java fails: Native resources unavailable Jun 3, 2025

Handle white spaces

268e79c

openjdk bot added the rfr Pull request is ready for review label Jun 3, 2025

prrace reviewed Jun 3, 2025

View reviewed changes

src/java.desktop/windows/native/libawt/windows/awt_Window.cpp Outdated Show resolved Hide resolved

anass-baya added 3 commits June 9, 2025 21:30

Merge branch 'openjdk:master' into JDK-8346952

7831957

Fix - 2

c3348d7

Remove global lock

af7209e

anass-baya requested review from prrace and mrserb June 10, 2025 22:14

mrserb reviewed Jun 10, 2025

View reviewed changes

Enhance comment

3175a0f

anass-baya requested a review from mrserb June 11, 2025 00:09

Reorder declaration

1eba0fc

openjdk bot removed the rfr Pull request is ready for review label Jun 11, 2025

anass-baya added 2 commits June 11, 2025 03:35

Add the new bug ID to the old test

bfc4ac1

Remove whitespace

577ba84

openjdk bot added the rfr Pull request is ready for review label Jun 12, 2025

Enhance the test

9103d25

mrserb reviewed Jun 23, 2025

View reviewed changes

anass-baya added 2 commits June 25, 2025 17:41

Delete NotifyStressTest

9262aa7

Add BogusFocusableWindowState

61906dd

BogusFocusableWindowState -2-

0a02b31

mrserb reviewed Jun 26, 2025

View reviewed changes

Enhanecments

ba8e40f

openjdk bot removed the rfr Pull request is ready for review label Jun 26, 2025

delete trailing whitespace

9434c98

openjdk bot added the rfr Pull request is ready for review label Jun 26, 2025

anass-baya requested a review from mrserb June 26, 2025 22:06

Remove trailing space

e458e6e

mrserb approved these changes Jun 30, 2025

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jun 30, 2025

openjdk bot added the sponsor Pull request is ready to be sponsored label Jun 30, 2025

8346952 : GetGraphicsStressTest.java fails: Native resources unavailable #25619

Are you sure you want to change the base?

8346952 : GetGraphicsStressTest.java fails: Native resources unavailable #25619

Conversation

anass-baya commented Jun 3, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Uh oh!

bridgekeeper bot commented Jun 3, 2025

Uh oh!

openjdk bot commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Jun 3, 2025

Uh oh!

mlbridge bot commented Jun 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

Uh oh!

mrserb Jun 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anass-baya Jun 11, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anass-baya Jun 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anass-baya Jun 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

anass-baya commented Jun 30, 2025

Uh oh!

openjdk bot commented Jun 30, 2025

Uh oh!

Uh oh!

anass-baya commented Jun 3, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Jun 3, 2025 •

edited

Loading

mlbridge bot commented Jun 3, 2025 •

edited

Loading

mrserb Jun 10, 2025 •

edited

Loading

anass-baya Jun 11, 2025 •

edited

Loading

anass-baya Jun 17, 2025 •

edited

Loading

anass-baya Jun 26, 2025 •

edited

Loading