8346307: [lworld] Clarify identity vs value in Class, Objects, and document limitations of value objects #1327

RogerRiggs · 2025-01-06T20:05:48Z

Add APINote and javadoc for IdentityException where it will be useful to know that identity or value objects are treated differently.
Simplified WeakHashMap javadoc updates for IdentityException.
Added note to System.identityHashCode to include value objects.
Added to class javadoc for IdentityHashMap for value objects.

Progress

Change must not contain extraneous whitespace

Issue

JDK-8346307: [lworld] Clarify identity vs value in Class, Objects, and document limitations of value objects (Bug - P4)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1327/head:pull/1327
$ git checkout pull/1327

Update a local copy of the PR:
$ git checkout pull/1327
$ git pull https://git.openjdk.org/valhalla.git pull/1327/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 1327

View PR using the GUI difftool:
$ git pr show -t 1327

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1327.diff

Using Webrev

Link to Webrev Comment

…IdentityException Add APINote and javadoc for IdentityException where it will be useful to know. Simplified WeakHashMap javadoc updates for IdentityException. Added note to System.identityHashCode to include value objects.

bridgekeeper · 2025-01-06T20:06:19Z

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into lworld will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2025-01-06T20:06:28Z

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8346307: [lworld] Clarify identity vs value in Class, Objects, and document limitations of value objects

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the lworld branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the lworld branch, type /integrate in a new comment.

mlbridge · 2025-01-06T20:10:32Z

Webrevs

…IdentityException Add APINote and javadoc for IdentityException where it will be useful to know. Updated Objects.hasIdentity to return true for non-null reference to identity class; else false Added Objects.isValueObject to return true for non-null reference to value class; else false Updated tests for value objects.

…tityexception' into 8346307-throws-identityexception

openjdk · 2025-01-13T22:06:23Z

⚠️ @RogerRiggs This pull request contains merges that bring in commits not present in the target repository. Since this is not a "merge style" pull request, these changes will be squashed when this pull request in integrated. If this is your intention, then please ignore this message. If you want to preserve the commit structure, you must change the title of this pull request to Merge <project>:<branch> where <project> is the name of another project in the OpenJDK organization (for example Merge jdk:master).

bridgekeeper · 2025-02-03T20:34:44Z

@RogerRiggs This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

liach · 2025-02-04T17:17:10Z

Does this intend to wait for openjdk/jdk#23395 or will it migrate from HTML after the taglet is available?

RogerRiggs · 2025-02-04T20:40:17Z

I've been trying out the various incarnations of the javadoc support to see how they work, but that can be a separate PR when it settles.

src/java.base/share/classes/java/lang/Class.java

bridgekeeper · 2025-03-19T23:12:44Z

@RogerRiggs This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

bridgekeeper · 2025-04-17T00:56:32Z

@RogerRiggs This pull request has been inactive for more than 8 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the /open pull request command.

RogerRiggs · 2025-04-17T19:32:55Z

/open Will merge and update

RogerRiggs · 2025-04-17T19:33:26Z

/open

openjdk · 2025-04-17T19:33:35Z

@RogerRiggs This pull request is now open

openjdk · 2025-04-17T19:33:42Z

@RogerRiggs This pull request is already open

bridgekeeper · 2025-05-15T21:37:26Z

@RogerRiggs This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply issue a /touch or /keepalive command to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

liach · 2025-05-16T16:45:22Z

PreviewNote isn't merged yet; we can revisit this one once that taglet is available here.

RogerRiggs · 2025-05-29T21:06:14Z

The PreviewNote tag has been delayed, the plan is to integrate these changes until it settles down.

liach · 2025-05-30T01:31:57Z

test/jdk/java/lang/Class/GenericStringTest.java

@@ -57,7 +57,7 @@ public static void main(String... args) throws ReflectiveOperationException {
                   new PlatformTestCase(java.lang.Enum.class,
                                        "public abstract class java.lang.Enum<E extends java.lang.Enum<E>>"),
                   new PlatformTestCase(java.util.Map.class,
-                                        "public abstract interface java.util.Map<K,V>"),
+                                        "public abstract value interface java.util.Map<K,V>"),


Hmm, isn't value redundant on interfaces?

openjdk bot added ready rfr labels Jan 6, 2025

RogerRiggs and others added 3 commits January 13, 2025 16:06

Merge branch 'openjdk:lworld' into 8346307-throws-identityexception

2aae8e6

Merge remote-tracking branch 'refs/remotes/origin/8346307-throws-iden…

850923b

…tityexception' into 8346307-throws-identityexception

RogerRiggs changed the title ~~8346307: [lworld] Document WeakHashMap and other apis that may throw IdentityException~~ 8346307: [lworld] Clarify identity vs value in Class, Objects, and document limitations of value objects Jan 13, 2025

openjdk bot removed the ready label Jan 13, 2025

openjdk bot added the ready label Feb 4, 2025

RogerRiggs added 2 commits February 4, 2025 15:56

Expand javadoc reference to Reference

d450add

Merge

4add60a

Sm0keySa1m0n reviewed Feb 16, 2025

View reviewed changes

src/java.base/share/classes/java/lang/Class.java Show resolved Hide resolved

Merge branch 'lworld' into 8346307-throws-identityexception

b26dbfa

RogerRiggs added 2 commits March 25, 2025 14:44

Merge branch 'lworld' into 8346307-throws-identityexception

2cd8776

Merge branch 'lworld' into 8346307-throws-identityexception

3d774c9

bridgekeeper bot closed this Apr 17, 2025

openjdk bot reopened this Apr 17, 2025

RogerRiggs added 3 commits May 23, 2025 15:16

Merge

9a8711f

Merge branch 'lworld' into 8346307-throws-identityexception

55940ce

Merge branch 'lworld' into 8346307-throws-identityexception

b6cd55b

liach reviewed May 30, 2025

View reviewed changes

8346307: [lworld] Clarify identity vs value in Class, Objects, and document limitations of value objects #1327

Are you sure you want to change the base?

8346307: [lworld] Clarify identity vs value in Class, Objects, and document limitations of value objects #1327

Uh oh!

Conversation

RogerRiggs commented Jan 6, 2025 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewing

Uh oh!

bridgekeeper bot commented Jan 6, 2025

Uh oh!

openjdk bot commented Jan 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mlbridge bot commented Jan 6, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

openjdk bot commented Jan 13, 2025

Uh oh!

bridgekeeper bot commented Feb 3, 2025

Uh oh!

liach commented Feb 4, 2025

Uh oh!

RogerRiggs commented Feb 4, 2025

Uh oh!

Uh oh!

bridgekeeper bot commented Mar 19, 2025

Uh oh!

bridgekeeper bot commented Apr 17, 2025

Uh oh!

RogerRiggs commented Apr 17, 2025

Uh oh!

RogerRiggs commented Apr 17, 2025

Uh oh!

openjdk bot commented Apr 17, 2025

Uh oh!

openjdk bot commented Apr 17, 2025

Uh oh!

bridgekeeper bot commented May 15, 2025

Uh oh!

liach commented May 16, 2025

Uh oh!

RogerRiggs commented May 29, 2025

Uh oh!

liach May 30, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

RogerRiggs commented Jan 6, 2025 •

edited by openjdk bot

Loading

openjdk bot commented Jan 6, 2025 •

edited

Loading

mlbridge bot commented Jan 6, 2025 •

edited

Loading