8343846: [lworld] implement spec changes to stack map tables #1333
Conversation
|
👋 Welcome back vromero! A progress list of the required criteria for merging this PR into |
|
❗ This change is not yet ready to be integrated. |
openjdk
bot
changed the title
|
|
| /** | ||
| * {@return the expanded unset fields} | ||
| */ | ||
| List<Integer> unSetFields(); |
There was a problem hiding this comment.
Use List<NameAndTypeEntry> please
There was a problem hiding this comment.
thanks for taking a look, will do
| */ | ||
| public static StackMapFrameInfo of(Label target, | ||
| List<VerificationTypeInfo> locals, | ||
| List<VerificationTypeInfo> stack) { | ||
| List<VerificationTypeInfo> stack, | ||
| List<Integer> unSetFields) { |
There was a problem hiding this comment.
Can keep the original one untouched for compatibility and add a new factory ofUnsetFields(List<NameAndTypeEntry>)
| @@ -572,7 +572,7 @@ public void write(Attribute<?> a, CodeAttribute lr) { | |||
| int offsetDelta = lr.labelToBci(frame.target()) - lastOffset - 1; | |||
| switch (frameType) { | |||
| case 247 -> { | |||
There was a problem hiding this comment.
Should print the assert unset here
Some stack maps classfile work, need testing
|
@vicente-romero-oracle this pull request can not be integrated into git checkout JDK-8343846
git fetch https://git.openjdk.org/valhalla.git lworld
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge lworld"
git push |
|
@vicente-romero-oracle This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
@vicente-romero-oracle This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
still experimental
Progress
Issue
Backport <hash>with the hash of the original commit. See Backports.Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/valhalla.git pull/1333/head:pull/1333$ git checkout pull/1333Update a local copy of the PR:
$ git checkout pull/1333$ git pull https://git.openjdk.org/valhalla.git pull/1333/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 1333View PR using the GUI difftool:
$ git pr show -t 1333Using diff file
Download this PR as a diff file:
https://git.openjdk.org/valhalla/pull/1333.diff